From: Sasha Levin <sasha.levin@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC v2 1/2] compiler: use compiler to detect integer overflows
Date: Sat, 29 Nov 2014 22:47:43 -0500 [thread overview]
Message-ID: <547A935F.6070601@oracle.com> (raw)
In-Reply-To: <CA+55aFzTc=vXUQ8ZrWWVj4DNmrZOEr3bcYpiGt6+KEVWPW-x2g@mail.gmail.com>
On 11/29/2014 01:08 PM, Linus Torvalds wrote:
> On Sat, Nov 29, 2014 at 7:07 AM, Sasha Levin <sasha.levin@oracle.com> wrote:
>> >
>> > Since we can't just change those to unsigned
> Sure we can. Just cast them. A signed start/len is bogus crap, it's a
> random wrong type.
But this is going on everywhere in fs/! It uses loff_t for pretty much anything,
even stuff which are obviously are unsigned (inode.i_size for example). Do you
think it's worth the effort to switch is all to unsigned?
Thanks,
Sasha
prev parent reply other threads:[~2014-11-30 3:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 23:58 [RFC v2 1/2] compiler: use compiler to detect integer overflows Sasha Levin
2014-11-26 23:58 ` [RFC v2 2/2] fs: correctly check for signed integer overflow in vfs_fallocate Sasha Levin
2014-11-27 0:33 ` [RFC v2 1/2] compiler: use compiler to detect integer overflows Linus Torvalds
2014-11-27 1:37 ` Sasha Levin
2014-11-27 3:13 ` Linus Torvalds
2014-11-29 15:07 ` Sasha Levin
2014-11-29 18:08 ` Linus Torvalds
2014-11-30 3:47 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547A935F.6070601@oracle.com \
--to=sasha.levin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).