From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752112AbaK3KIz (ORCPT ); Sun, 30 Nov 2014 05:08:55 -0500 Received: from mout.web.de ([212.227.17.11]:56159 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751561AbaK3KIx (ORCPT ); Sun, 30 Nov 2014 05:08:53 -0500 Message-ID: <547AECA4.3050800@users.sourceforge.net> Date: Sun, 30 Nov 2014 11:08:36 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Len Brown , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH 1/1] ACPI: Deletion of an unnecessary check before the function call "pci_dev_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:9nZPhlKKqXVdteGIU6005pwLaR7QAJF0W0RXgKvRPTAqRb6AZ8c aak4A9mu08HPrkipUqPlaIgWiXvWxDbvgxmuQ3yh/gCKPE2zPNKouDoeN3apVOvyqOplJxr 526m6JZXXxGbZS9O1NVo4gZtxCGUT7ekMLdPfmMi3WDWjB0xHHEgjNs2lnriT7SOYiHOKeP VfuvD+NQsn3pJtt/FfNOw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 30 Nov 2014 10:59:10 +0100 The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/acpi/ioapic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c index 9a631a6..35963d3 100644 --- a/drivers/acpi/ioapic.c +++ b/drivers/acpi/ioapic.c @@ -185,8 +185,7 @@ exit_disable: if (dev) pci_disable_device(dev); exit_put: - if (dev) - pci_dev_put(dev); + pci_dev_put(dev); exit_free: kfree(ioapic); exit: -- 2.1.3