From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751876AbaLCTOU (ORCPT ); Wed, 3 Dec 2014 14:14:20 -0500 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:43328 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592AbaLCTOQ (ORCPT ); Wed, 3 Dec 2014 14:14:16 -0500 X-IronPort-AV: E=Sophos;i="5.07,509,1413270000"; d="scan'208";a="52367760" Message-ID: <547F60E5.50705@broadcom.com> Date: Wed, 3 Dec 2014 20:13:41 +0100 From: Arend van Spriel User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.24) Gecko/20111103 Lightning/1.0b2 Thunderbird/3.1.16 MIME-Version: 1.0 To: SF Markus Elfring CC: Dan Carpenter , Julia Lawall , , , , "Jonathan Corbet" , OGAWA Hirofumi , Coccinelle , , "Johannes Berg" , "Luis R. Rodriguez" Subject: Re: [patch] CodingStyle: add some more error handling guidelines References: <20141202085950.GA13434@mwanda> <547F0297.6030202@users.sourceforge.net> <20141203124511.GR5048@mwanda> <547F0977.7090908@users.sourceforge.net> <20141203132002.GT5048@mwanda> <547F0F2A.3060708@users.sourceforge.net> <547F1942.5060502@broadcom.com> <547F33AC.50002@users.sourceforge.net> In-Reply-To: <547F33AC.50002@users.sourceforge.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/14 17:00, SF Markus Elfring wrote: >>> Which name pattern do you find more appropriate in such >>> an use case? >> >> I think Dan wants the label to be descriptive about the tasks >> needed in the exception handling itself. > > I would usually prefer also such a target-oriented labelling > for the affected identifiers. > How are the chances to express an expectation in this direction > unambiguously for the proposed coding style update? > > >> This makes sense as the exception handling steps may be reused >> for different failures in the code. > > I would stress a different reason from my point of view. I meant as apposed to using a goto-/source-oriented labelling. Please provide your point of view. That way the explanations given in this email exchange might be incorporated in the next round of the proposed update or at least be used as input. Regards, Arend