From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933221AbaLDWKu (ORCPT ); Thu, 4 Dec 2014 17:10:50 -0500 Received: from mout.web.de ([212.227.15.4]:52364 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752997AbaLDWKr (ORCPT ); Thu, 4 Dec 2014 17:10:47 -0500 Message-ID: <5480DBDE.7040604@users.sourceforge.net> Date: Thu, 04 Dec 2014 23:10:38 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Sergei Shtylyov , Paul Mackerras , linux-ppp@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547B4886.4080406@users.sourceforge.net> <547B496E.604@users.sourceforge.net> <547C5CBC.6060607@cogentembedded.com> <547C82A6.2030808@users.sourceforge.net> <547CA157.1080401@cogentembedded.com> <5480DA32.8000201@users.sourceforge.net> In-Reply-To: <5480DA32.8000201@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:TUgskJCvWyZ7a5TpYLyTyAZPvUPx9xV7ZBHwJ1PUGzPBjIt3B5I mfRhfHrbJryT4qD8pSMShXIRq5vIf6JYRm+6t1EA8HIYIfX+uwpGkapTEVQr0IfDDF0KhcB PN+mi3lGIO519P+MWLi5BsS7PKoxAoyv6xkMgrWL+6LnLozNIxNSO1O0g2+n+UDi5mUB1eW 0lyPsMCPJAMWMhwXnLwdw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 4 Dec 2014 18:28:52 +0100 The mppe_rekey() function contained a few update candidates. * Curly brackets were still used around a single function call "printk". * Unwanted space characters Let us improve these implementation details according to the current Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ppp/ppp_mppe.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c index 911b216..84b7bce 100644 --- a/drivers/net/ppp/ppp_mppe.c +++ b/drivers/net/ppp/ppp_mppe.c @@ -172,9 +172,8 @@ static void mppe_rekey(struct ppp_mppe_state * state, int initial_key) setup_sg(sg_in, state->sha1_digest, state->keylen); setup_sg(sg_out, state->session_key, state->keylen); if (crypto_blkcipher_encrypt(&desc, sg_out, sg_in, - state->keylen) != 0) { - printk(KERN_WARNING "mppe_rekey: cipher_encrypt failed\n"); - } + state->keylen) != 0) + pr_warn("mppe_rekey: cipher_encrypt failed\n"); } else { memcpy(state->session_key, state->sha1_digest, state->keylen); } -- 2.1.3