From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761437AbdDSJDW (ORCPT ); Wed, 19 Apr 2017 05:03:22 -0400 Received: from gloria.sntech.de ([95.129.55.99]:42050 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761395AbdDSJCw (ORCPT ); Wed, 19 Apr 2017 05:02:52 -0400 From: Heiko Stuebner To: Guillaume Tucker Cc: Rob Herring , Mark Rutland , Neil Armstrong , Sjoerd Simons , Enric Balletbo i Serra , John Reitan , Wookey , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] dt-bindings: gpu: add bindings for the ARM Mali Midgard GPU Date: Wed, 19 Apr 2017 11:02:44 +0200 Message-ID: <5481965.3RkcDb038R@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <96021d989387d9aaff039efebd66aa3bfe667941.1492588180.git.guillaume.tucker@collabora.com> References: <96021d989387d9aaff039efebd66aa3bfe667941.1492588180.git.guillaume.tucker@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 19. April 2017, 09:06:17 CEST schrieb Guillaume Tucker: > The ARM Mali Midgard GPU family is present in a number of SoCs > from many different vendors such as Samsung Exynos and Rockchip. > > Import the device tree bindings documentation from the r16p0 > release of the Mali Midgard GPU kernel driver: > > https://developer.arm.com/-/media/Files/downloads/mali-drivers/kernel/mali-midgard-gpu/TX011-SW-99002-r16p0-00rel0.tgz > > The "compatible" property strings have been redesigned to explicitly > list all the Mali Midgard GPU types and include optional vendor ones. > > The "clock-names" property has been dropped as only one clock is used > by the Mali Midgard driver which now needs to call clk_get with NULL. > > The "interrupt-names" property values have been converted to > lower-case: "job", "mmu" and "gpu". > > The following optional bindings have been omitted in this initial > version as they are only used in very specific cases: > > * snoop_enable_smc > * snoop_disable_smc > * jm_config > * power_model > * system-coherency > * ipa-model > > The example has been simplified accordingly. > > The copyright and GPL licence header has been removed as deemed not > necessary. > > CC: John Reitan > Tested-by: Enric Balletbo i Serra > Signed-off-by: Guillaume Tucker > --- > .../devicetree/bindings/gpu/arm,mali-midgard.txt | 57 ++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > new file mode 100644 > index 000000000000..917c4f8d178f > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > @@ -0,0 +1,57 @@ > +ARM Mali Midgard GPU > +==================== > + > +Required properties: > + > +- compatible : > + * Must be one of the following: > + + "arm,mali-t60x" > + + "arm,mali-t62x" > + + "arm,mali-t720" > + + "arm,mali-t760" > + + "arm,mali-t820" > + + "arm,mali-t830" > + + "arm,mali-t860" > + + "arm,mali-t880" > + * And, optionally, one of the vendor specific compatible: > + + "amlogic,meson-gxm-mali" Please add a "rockchip,rk3288-mali" as well :-) , as I don't trust that the generic compatible will be enough for all time and having that already defined makes fixing the per soc things later a lot easier. Thanks Heiko > + > +- reg : Physical base address of the device and length of the register area. > + > +- interrupts : Contains the three IRQ lines required by Mali Midgard devices. > + > +- interrupt-names : Contains the names of IRQ resources in the order they were > + provided in the interrupts property. Must contain: "job", "mmu", "gpu". > + > + > +Optional properties: > + > +- clocks : Phandle to clock for the Mali Midgard device. > + > +- mali-supply : Phandle to regulator for the Mali device. Refer to > + Documentation/devicetree/bindings/regulator/regulator.txt for details. > + > +- operating-points : Refer to Documentation/devicetree/bindings/power/opp.txt > + for details. > + > + > +Example for a Mali-T602: > + > +gpu@fc010000 { > + compatible = "arm,mali-t60x", "arm,mali-midgard"; > + reg = <0xfc010000 0x4000>; > + interrupts = <0 36 4>, <0 37 4>, <0 38 4>; > + interrupt-names = "job", "mmu", "gpu"; > + clocks = <&pclk_mali>; > + mali-supply = <&vdd_mali>; > + operating-points = < > + /* KHz uV */ > + 533000 1250000, > + 450000 1150000, > + 400000 1125000, > + 350000 1075000, > + 266000 1025000, > + 160000 925000, > + 100000 912500, > + >; > +}; >