linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Handle PM_SUSPEND_TO_IDLE suspend_state_t
Date: Mon, 19 Feb 2018 21:59:13 +0100	[thread overview]
Message-ID: <5486ab34-4e5b-e2d5-9475-4d7e24a0cda6@redhat.com> (raw)
In-Reply-To: <20180219113444.GA32761@sirena.org.uk>

Hi,

On 19-02-18 12:34, Mark Brown wrote:
> On Sun, Feb 18, 2018 at 06:04:24PM +0100, Hans de Goede wrote:
>> The regulator framework is used on x86 in some cases now and x86 has
>> a PM_SUSPEND_TO_IDLE suspend_state_t, treat this as PM_SUSPEND_STANDBY,
>> this fixes these errors on resume:
> 
> This was already fixed by Geert.

There are multiple callers of regulator_get_suspend_state() in
drivers/regulator/core.c, I assume you refer to this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/regulator/core.c?id=57a0dd187956ea04870f4bbbf25a63c425ee7cad

Even with that commit I'm still seeing these errors on resume:

[  753.064002] dpm_run_callback(): regulator_resume_early+0x0/0x60 returns -22
[  753.064014] PM: Device regulator.0 failed to resume early: error -22

These are caused by the -EINVAL return after the
regulator_get_suspend_state() call in
_regulator_resume_early() and there are other callers
of regulator_get_suspend_state() which return -EINVAL
too.

I think just returning 0 in this case makes sense, but it
looks like that needs to be done in several places.

Regards,

Hans

  reply	other threads:[~2018-02-19 20:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-18 17:04 [PATCH] regulator: core: Handle PM_SUSPEND_TO_IDLE suspend_state_t Hans de Goede
2018-02-19 11:34 ` Mark Brown
2018-02-19 20:59   ` Hans de Goede [this message]
2018-02-20 11:47     ` Mark Brown
2018-02-20 12:12       ` Hans de Goede
2018-02-20 12:41         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5486ab34-4e5b-e2d5-9475-4d7e24a0cda6@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).