From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: Alexandru Chirvasitu <achirvasub@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Dexuan Cui <decui@microsoft.com>, Pavel Machek <pavel@ucw.cz>,
kernel list <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Mikael Pettersson <mikpelinux@gmail.com>,
Josh Poulson <jopoulso@microsoft.com>,
"Mihai Costache (Cloudbase Solutions SRL)"
<v-micos@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Marc Zyngier <marc.zyngier@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
Simon Xiao <sixiao@microsoft.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Jork Loeser <Jork.Loeser@microsoft.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
KY Srinivasan <kys@microsoft.com>
Subject: Re: PROBLEM: 4.15.0-rc3 APIC causes lockups on Core 2 Duo laptop
Date: Wed, 27 Dec 2017 16:14:23 +0800 [thread overview]
Message-ID: <548c814c-7e24-00c0-3436-26f2704cb427@cn.fujitsu.com> (raw)
In-Reply-To: <20171223200112.GC1138@arch-chirva.localdomain>
Hi Alexandru,
At 12/24/2017 04:01 AM, Alexandru Chirvasitu wrote:
> On Sat, Dec 23, 2017 at 02:32:52PM +0100, Thomas Gleixner wrote:
>> On Sat, 23 Dec 2017, Dexuan Cui wrote:
>>
>>>> From: Alexandru Chirvasitu [mailto:achirvasub@gmail.com]
>>>> Sent: Friday, December 22, 2017 14:29
>>>>
>>>> The output of that precise command run just now on a freshly-compiled
>>>> copy of that commit is attached.
>>>>
>>>> On Fri, Dec 22, 2017 at 09:31:28PM +0000, Dexuan Cui wrote:
>>>>>> From: Alexandru Chirvasitu [mailto:achirvasub@gmail.com]
>>>>>> Sent: Friday, December 22, 2017 06:21
>>>>>>
>>>>>> In the absence of logs, the best I can do at the moment is attach a
>>>>>> picture of the screen I am presented with on the boot
>>>>>> attempt.
>>>>>> Alex
>>>>>
>>>>> The panic happens in irq_matrix_assign_system+0x4e/0xd0 in your picture.
>>>>> IMO we should find which line of code causes the panic. I suppose
>>>>> "objdump -D kernel/irq/matrix.o" can help to do that.
>>>>>
>>>>> Thanks,
>>>>> -- Dexuan
>>>
>>> The BUG_ON panic happens at line 147:
>>> BUG_ON(!test_and_clear_bit(bit, cm->alloc_map));
>>>
There are 2 bugs in your laptop:
1. Hard lockups on both CPUs after login
2. panic with "apic=debug"
For the 2th bug, please try the following patch(need Thomas confirmation
:) ) in Linux 4.15-rc5. I think it can fix the panic.
If the 2th bug fixed, let's back to the 1th bug:
Is Linus current head 4.15-rc5 bad as well?
If yes, Please using "apic=debug" and give the dmesg log.
Thanks,
dou.
------------------------8<-------------------------------------------
irq/matrix: Remove the overused BUGON() in irq_matrix_assign_system()
Currently, x86 marks the preallocated legacy interrupts when initializing
IRQ(native_init_IRQ), but will clear them if they are not activated in
vector_configure_legacy().
So, in irq_matrix_assign_system(), replacing an legacy vector which may
not allocated in a cpumap->alloc_map[] with a system vector will trigger
the BUGON();
Remove the BUGON().
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
---
kernel/irq/matrix.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/irq/matrix.c b/kernel/irq/matrix.c
index 0ba0dd8863a7..876cbeab9ca2 100644
--- a/kernel/irq/matrix.c
+++ b/kernel/irq/matrix.c
@@ -143,11 +143,12 @@ void irq_matrix_assign_system(struct irq_matrix
*m, unsigned int bit,
BUG_ON(m->online_maps > 1 || (m->online_maps && !replace));
set_bit(bit, m->system_map);
- if (replace) {
- BUG_ON(!test_and_clear_bit(bit, cm->alloc_map));
+
+ if (replace && test_and_clear_bit(bit, cm->alloc_map)){
cm->allocated--;
m->total_allocated--;
}
+
if (bit >= m->alloc_start && bit < m->alloc_end)
m->systembits_inalloc++;
--
next prev parent reply other threads:[~2017-12-27 8:14 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171218082011.GA24638@arch-chirva.localdomain>
2017-12-18 10:11 ` PROBLEM: 4.15.0-rc3 APIC causes lockups on Core 2 Duo laptop Pavel Machek
2017-12-19 8:34 ` Alexandru Chirvasitu
2017-12-20 0:31 ` Thomas Gleixner
2017-12-20 3:58 ` Dou Liyang
2017-12-20 13:19 ` Alexandru Chirvasitu
2017-12-20 19:45 ` Alexandru Chirvasitu
2017-12-21 2:23 ` Alexandru Chirvasitu
2017-12-22 10:28 ` Dou Liyang
[not found] ` <20171222142053.3cbhi2nhh24w7yoo@D-69-91-141-110.dhcp4.washington.edu>
2017-12-22 21:31 ` Dexuan Cui
[not found] ` <20171222222917.GA1138@arch-chirva.localdomain>
2017-12-23 1:35 ` Dexuan Cui
2017-12-23 4:51 ` Alexandru Chirvasitu
2017-12-23 13:32 ` Thomas Gleixner
2017-12-23 20:01 ` Alexandru Chirvasitu
2017-12-27 8:14 ` Dou Liyang [this message]
2017-12-27 16:18 ` Alexandru Chirvasitu
[not found] ` <20171227195007.GF1410@arch-chirva.localdomain>
2017-12-27 23:13 ` Alexandru Chirvasitu
2017-12-28 2:06 ` Dou Liyang
2017-12-28 2:51 ` Alexandru Chirvasitu
2017-12-28 10:23 ` Dou Liyang
2017-12-24 3:29 ` Dou Liyang
2017-12-28 11:00 ` Thomas Gleixner
2017-12-28 14:21 ` Alexandru Chirvasitu
2017-12-28 14:48 ` Thomas Gleixner
2017-12-28 15:48 ` Alexandru Chirvasitu
2017-12-28 16:05 ` Alexandru Chirvasitu
2017-12-28 16:10 ` Thomas Gleixner
2017-12-28 17:22 ` Alexandru Chirvasitu
2017-12-28 17:29 ` Thomas Gleixner
2017-12-28 17:50 ` Alexandru Chirvasitu
2017-12-28 18:32 ` Thomas Gleixner
2017-12-28 21:54 ` Thomas Gleixner
2017-12-28 22:50 ` Alexandru Chirvasitu
2017-12-28 22:57 ` Thomas Gleixner
2017-12-28 23:19 ` Thomas Gleixner
2017-12-28 23:30 ` Alexandru Chirvasitu
2017-12-28 23:36 ` Thomas Gleixner
2017-12-28 23:59 ` Alexandru Chirvasitu
2017-12-29 8:07 ` Thomas Gleixner
2017-12-29 11:49 ` Alexandru Chirvasitu
2017-12-29 12:22 ` Alexandru Chirvasitu
2017-12-29 13:09 ` Thomas Gleixner
2017-12-29 14:06 ` Alexandru Chirvasitu
2017-12-29 0:15 ` Bjorn Helgaas
2017-12-29 0:38 ` Alexandru Chirvasitu
2017-12-28 11:03 ` Thomas Gleixner
2017-12-28 19:01 ` Dexuan Cui
2017-12-28 20:14 ` Thomas Gleixner
2017-12-28 17:17 IRQ behaivour has been changed from v4.14 to v4.15-rc1 Shevchenko, Andriy
2017-12-28 17:21 ` Thomas Gleixner
2017-12-28 17:34 ` Andy Shevchenko
2017-12-28 17:44 ` Thomas Gleixner
2017-12-28 19:31 ` Andy Shevchenko
2017-12-28 19:36 ` Andy Shevchenko
2017-12-28 20:18 ` Thomas Gleixner
2017-12-28 21:03 ` Andy Shevchenko
2017-12-28 21:31 ` Thomas Gleixner
2017-12-28 21:59 ` Thomas Gleixner
2017-12-29 12:06 ` Andy Shevchenko
2017-12-29 13:10 ` Thomas Gleixner
2017-12-29 14:27 ` Andy Shevchenko
2017-12-29 20:20 ` [tip:irq/urgent] genirq/msi, x86/vector: Prevent reservation mode for non maskable MSI tip-bot for Thomas Gleixner
2017-12-28 17:23 ` IRQ behaivour has been changed from v4.14 to v4.15-rc1 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548c814c-7e24-00c0-3436-26f2704cb427@cn.fujitsu.com \
--to=douly.fnst@cn.fujitsu.com \
--cc=Jork.Loeser@microsoft.com \
--cc=achirvasub@gmail.com \
--cc=bhelgaas@google.com \
--cc=decui@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jopoulso@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=marc.zyngier@arm.com \
--cc=mikpelinux@gmail.com \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=saeedm@mellanox.com \
--cc=sixiao@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=v-micos@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).