From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752826AbaLTMEt (ORCPT ); Sat, 20 Dec 2014 07:04:49 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:35871 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752739AbaLTMEr (ORCPT ); Sat, 20 Dec 2014 07:04:47 -0500 Message-ID: <549565B3.5070504@roeck-us.net> Date: Sat, 20 Dec 2014 04:04:03 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: =?UTF-8?B?UGFsaSBSb2jDoXI=?= CC: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Valdis.Kletnieks@vt.edu, Steven Honeyman , Jean Delvare , Gabriele Mazzotta , Jochen Eisinger Subject: Re: [PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM multiplier References: <1418155621-21644-1-git-send-email-pali.rohar@gmail.com> <201412191951.25562@pali> <20141219192808.GA8493@roeck-us.net> <201412200957.38638@pali> In-Reply-To: <201412200957.38638@pali> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020205.549565DF.0073,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 6 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/20/2014 12:57 AM, Pali Rohár wrote: > On Friday 19 December 2014 20:28:08 Guenter Roeck wrote: >> On Fri, Dec 19, 2014 at 07:51:25PM +0100, Pali Rohár wrote: >>> On Friday 19 December 2014 19:32:37 Guenter Roeck wrote: >>>>> -static int i8k_fan_mult; >>>>> -static int i8k_pwm_mult; >>>>> -static int i8k_fan_max = I8K_FAN_HIGH; >>>>> +static int i8k_fan_mult[2]; >>>>> +static int i8k_pwm_mult[2]; >>>>> +static int i8k_fan_max[2]; >>>> >>>> The rationale for this change is not explained in the >>>> commit log. >>>> >>>> Do you have any indication that those values would ever be >>>> different for the two fans, ie that you actually need >>>> arrays here ? >>> >>> I do not know... But if we decide to use only single value >>> for multiplier and max value which fan to use for >>> autodetection? >> >> That does not answer my question. That you can not decide >> which fan to use for auto-detection does not mean that the >> result of that auto-detection would be different for >> different fans. >> > > Really I do not know if some dell products which have more fans > (some Precision models have 2) and each fan is using different > multiplier or has different max speed value. > "I do not know" is not a reason for introducing such code. Guenter