From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753700AbaLUSwO (ORCPT ); Sun, 21 Dec 2014 13:52:14 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:43502 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043AbaLUSwN (ORCPT ); Sun, 21 Dec 2014 13:52:13 -0500 Message-ID: <549716A7.2040207@roeck-us.net> Date: Sun, 21 Dec 2014 10:51:19 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: =?UTF-8?B?UGFsaSBSb2jDoXI=?= CC: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Valdis.Kletnieks@vt.edu, Steven Honeyman , Jean Delvare , Gabriele Mazzotta , Jochen Eisinger Subject: Re: [PATCH v4] i8k: Autodetect maximal fan speed and fan RPM multiplier References: <1419153618-6930-1-git-send-email-pali.rohar@gmail.com> <1419182630-20211-1-git-send-email-pali.rohar@gmail.com> <54971116.8030504@roeck-us.net> <201412211940.06980@pali> In-Reply-To: <201412211940.06980@pali> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020205.549716DD.007C,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 6 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/21/2014 10:40 AM, Pali Rohár wrote: > On Sunday 21 December 2014 19:27:34 Guenter Roeck wrote: >> On 12/21/2014 09:23 AM, Pali Rohár wrote: >>> This patch adds new function i8k_get_fan_nominal_speed() for >>> doing SMM call which will return nominal fan RPM for >>> specified fan speed. It returns nominal RPM value at which >>> fan operate when speed (0, 1, 2, 3) is set. It looks like >>> RPM value is not accurate, but still provides very useful >>> information. >>> >>> First it can be used to validate if certain fan speed could >>> be accepted by SMM for setting fan speed and we can use >>> this routine to detect maximal fan speed. >>> >>> Second it returns RPM value, so we can check if value looks >>> correct with multiplier 30 or multiplier 1 (until now only >>> these two multiplier were used). If RPM value with >>> multiplier 30 is too high, then multiplier 1 is used. >>> >>> In case when SMM reports that new function is not supported >>> we will fallback to old hardcoded values. Maximal fan speed >>> would be 2 and RPM multiplier 30. >>> >>> Signed-off-by: Pali Rohár >>> Tested-by: Pali Rohár >> >> Tested-by the submitter is kind of implied. >> >> Anyway, this patch does not apply to 3.19-rc1, nor to 3.18. >> What is your baseline ? Can you rebase to 3.19-rc1 ? >> Or do I need to apply some other patch first ? >> >> Thanks, >> Guenter > > You need to apply these old patches: > i8k: Add support for temperature sensor labels > i8k: Register only temperature sensors which have labels > i8k: Return -ENODATA for invalid temperature > i8k: Rework error retries > I think it would make sense to re-send the entire series at this point (including my patch and all Reviewed-by: tags). Problem is that not all patches have a version number (for example there are multiple versions of the label patch, but the version I reviewed does not have version information). This makes it very difficult to find the correct (reviewed) version, and I suspect that Greg may neither have the time nor the desire to do it. Thanks, Guenter