From: Oleg Drokin <oleg.drokin@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Shawn Lin <shawn.lin@rock-chips.com>,
Andreas Dilger <andreas.dilger@intel.com>,
<lustre-devel@lists.lustre.org>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging/lustre: avoid zero buf for the first time
Date: Fri, 26 Aug 2016 15:48:27 -0400 [thread overview]
Message-ID: <5498CEC3-3AB9-487B-9899-3E9372D2C575@intel.com> (raw)
In-Reply-To: <20160822100408.GA11890@kroah.com>
Hello!
On Aug 22, 2016, at 6:04 AM, Greg Kroah-Hartman wrote:
> On Mon, Aug 22, 2016 at 04:46:04PM +0800, Shawn Lin wrote:
>> We only need to zero it when repeating in order to
>> avoid old garbage. Let's improve it by moving this
>> before we repeat the calculation to save some cpu
>> cycle.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> Have you noticed a change with this in a benchmark?
>
> If not, is it really worth it?
The other problem is we would need to remember to memset it
should there be more paths jumping to the repeat label
which might be easy to miss,
so we are probably better off without this patch.
> I need an ack from the lustre developers before taking patches like
> this...
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2016-08-26 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 8:46 [PATCH] staging/lustre: avoid zero buf for the first time Shawn Lin
2016-08-22 10:04 ` Greg Kroah-Hartman
2016-08-26 19:48 ` Oleg Drokin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5498CEC3-3AB9-487B-9899-3E9372D2C575@intel.com \
--to=oleg.drokin@intel.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).