From: Jonathan Cameron <jic23@kernel.org>
To: "Tirdea, Irina" <irina.tirdea@intel.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Dogaru, Vlad" <vlad.dogaru@intel.com>,
"Baluta, Daniel" <daniel.baluta@intel.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>
Subject: Re: [PATCH 4/8] iio: core: Introduce IO_CHAN_INFO_CALIBWEIGHT
Date: Thu, 01 Jan 2015 10:37:57 +0000 [thread overview]
Message-ID: <54A52385.8060700@kernel.org> (raw)
In-Reply-To: <1F3AC3675D538145B1661F571FE1805F199F7B06@irsmsx105.ger.corp.intel.com>
On 29/12/14 15:05, Tirdea, Irina wrote:
>
>
>> -----Original Message-----
>> From: Jonathan Cameron [mailto:jic23@kernel.org]
>> Sent: 26 December, 2014 15:31
>> To: Tirdea, Irina; linux-iio@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org; Dogaru, Vlad; Baluta, Daniel; Hartmut Knaack; Lars-Peter Clausen; Peter Meerwald
>> Subject: Re: [PATCH 4/8] iio: core: Introduce IO_CHAN_INFO_CALIBWEIGHT
>>
>> On 19/12/14 22:57, Irina Tirdea wrote:
>>> Some devices need the weight of the user to compute other
>>> parameters. One of this devices is Freescale's MMA9553L
>>> (http://www.freescale.com/files/sensors/doc/ref_manual/MMA9553LSWRM.pdf)
>>> that needs the weight of the user to compute the number of calories burnt.
>>>
>>> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
>>> ---
>>> Documentation/ABI/testing/sysfs-bus-iio | 7 +++++++
>>> drivers/iio/industrialio-core.c | 1 +
>>> include/linux/iio/iio.h | 1 +
>>> 3 files changed, 9 insertions(+)
>>>
>>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
>>> index 07acef7..e480175 100644
>>> --- a/Documentation/ABI/testing/sysfs-bus-iio
>>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
>>> @@ -351,6 +351,13 @@ Description:
>>> to compute the stride length, distance, speed and activity
>>> type.
>>>
>>> +What: /sys/bus/iio/devices/iio:deviceX/in_steps_calibweight
>>> +KernelVersion: 3.19
>>> +Contact: linux-iio@vger.kernel.org
>>> +Description:
>>> + Weight of the user (in kg). It is needed by some pedometers
>>> + to compute the calories burnt by the user.
>> How about grams? Nice to keep to SI units going forward (I appreciate we
>> have broken that for what seemed like good reasons at the time) in one
>> or two places, but it makes it much harder to define consistent interfaces in the
>> long run.
>
> According to SI [1] kg is the base unit for mass, so this was the obvious first choice.
I'd forgotten that piece if 'entirely intuitive' unit choice ;)
> I have nothing against using grams, but it is not clear to me why using grams would make it easier to define consistent interfaces in the long run.
> I am probably missing something, so could you please clarify this?
kg fine as we have a good argument for why ;)
The consistent interface bit comes when we start getting compound units if we had picked
non SI choices (such is mA and mV - which we are stuck with unfortunately).
Now as Joules are kg m^2 s^-2 for example, we are on good grounds with the kg.
>
> Thanks,
> Irina
>
> [1] http://www.bipm.org/en/measurement-units/
>
>> J
>>> +
>>> What: /sys/bus/iio/devices/iio:deviceX/in_accel_scale_available
>>> What: /sys/.../iio:deviceX/in_voltageX_scale_available
>>> What: /sys/.../iio:deviceX/in_voltage-voltage_scale_available
>>> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
>>> index 5e50aca..4c435c8 100644
>>> --- a/drivers/iio/industrialio-core.c
>>> +++ b/drivers/iio/industrialio-core.c
>>> @@ -124,6 +124,7 @@ static const char * const iio_chan_info_postfix[] = {
>>> [IIO_CHAN_INFO_INT_TIME] = "integration_time",
>>> [IIO_CHAN_INFO_ENABLE] = "en",
>>> [IIO_CHAN_INFO_CALIBHEIGHT] = "calibheight",
>>> + [IIO_CHAN_INFO_CALIBWEIGHT] = "calibweight",
>>> };
>>>
>>> /**
>>> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
>>> index 878d861..752a929 100644
>>> --- a/include/linux/iio/iio.h
>>> +++ b/include/linux/iio/iio.h
>>> @@ -40,6 +40,7 @@ enum iio_chan_info_enum {
>>> IIO_CHAN_INFO_INT_TIME,
>>> IIO_CHAN_INFO_ENABLE,
>>> IIO_CHAN_INFO_CALIBHEIGHT,
>>> + IIO_CHAN_INFO_CALIBWEIGHT,
>>> };
>>>
>>> enum iio_shared_by {
>>>
>
next prev parent reply other threads:[~2015-01-01 10:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 22:57 [PATCH 0/8] Add MMA9553 driver & PM support for MMA9551 Irina Tirdea
2014-12-19 22:57 ` [PATCH 1/8] iio: core: Introduce CALORIES channel type Irina Tirdea
2014-12-26 13:26 ` Jonathan Cameron
2014-12-29 14:42 ` Tirdea, Irina
2015-01-01 10:29 ` Jonathan Cameron
2015-01-11 13:44 ` Tirdea, Irina
2014-12-19 22:57 ` [PATCH 2/8] iio: core: Introduce DISTANCE " Irina Tirdea
2014-12-19 22:57 ` [PATCH 3/8] iio: core: Introduce SPEED " Irina Tirdea
2014-12-26 13:28 ` Jonathan Cameron
2014-12-29 18:13 ` Tirdea, Irina
2015-01-01 10:34 ` Jonathan Cameron
2015-01-11 13:47 ` Tirdea, Irina
2014-12-19 22:57 ` [PATCH 4/8] iio: core: Introduce IO_CHAN_INFO_CALIBWEIGHT Irina Tirdea
2014-12-26 13:31 ` Jonathan Cameron
2014-12-29 15:05 ` Tirdea, Irina
2015-01-01 10:37 ` Jonathan Cameron [this message]
2014-12-19 22:57 ` [PATCH 5/8] iio: core: Introduce IIO_CHAN_INFO_CALIBGENDER Irina Tirdea
2014-12-26 13:29 ` Jonathan Cameron
2014-12-29 19:59 ` Tirdea, Irina
2014-12-19 22:57 ` [PATCH 6/8] iio: accel: mma9551: Add runtime pm support Irina Tirdea
2014-12-19 22:57 ` [PATCH 7/8] iio: accel: mma9551: split driver to expose mma955x api Irina Tirdea
2015-01-01 10:58 ` Jonathan Cameron
2015-01-11 13:52 ` Tirdea, Irina
2014-12-19 22:57 ` [PATCH 8/8] iio: add driver for Freescale MMA9553 Irina Tirdea
2015-01-01 11:58 ` Jonathan Cameron
2015-01-11 15:10 ` Tirdea, Irina
2015-01-11 17:51 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A52385.8060700@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=irina.tirdea@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=vlad.dogaru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).