From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752709AbbADNMI (ORCPT ); Sun, 4 Jan 2015 08:12:08 -0500 Received: from mout.web.de ([212.227.15.14]:58945 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743AbbADNMG (ORCPT ); Sun, 4 Jan 2015 08:12:06 -0500 Message-ID: <54A93C1E.4050200@users.sourceforge.net> Date: Sun, 04 Jan 2015 14:11:58 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Liam Girdwood , Mark Brown CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH 7/13] ASoC: fsi: Deletion of unnecessary checks before the function call "clk_enable" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54A9355F.4050102@users.sourceforge.net> In-Reply-To: <54A9355F.4050102@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:qzZbK4/ZXGj6WuoQYrSAtYSpiSOYlq6iGOtyUo8X0LAq01FU7k3 A/khZlwe4rsMQTHUExnsW/U3GP1070jADcK4VDe/9Pfc/ILuuIVqjGbV7G4hPJi8WGYUs6h /opMmhUNoQxg62i6dFn08Xy5w84zbz8VvdKzhxq5BDjefPooBygmMyGfXw18vudqLiL7hOQ 2YOwU/EMeNPDNvb0R07xQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 3 Jan 2015 19:25:55 +0100 The clk_enable() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/soc/sh/fsi.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c index 8869971..d49f25f 100644 --- a/sound/soc/sh/fsi.c +++ b/sound/soc/sh/fsi.c @@ -820,12 +820,9 @@ static int fsi_clk_enable(struct device *dev, return ret; } - if (clock->xck) - clk_enable(clock->xck); - if (clock->ick) - clk_enable(clock->ick); - if (clock->div) - clk_enable(clock->div); + clk_enable(clock->xck); + clk_enable(clock->ick); + clk_enable(clock->div); clock->count++; } -- 2.2.1