From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, monstr@monstr.eu,
Olof Johansson <olof@lixom.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
Peter Hurley <peter@hurleysoftware.com>,
Alan Cox <alan@linux.intel.com>, Tony Lindgren <tony@atomide.com>,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/2] tty: serial: 8250_core: Check that port->line is >=0
Date: Fri, 16 Jan 2015 12:33:09 +0100 [thread overview]
Message-ID: <54B8F6F5.1030204@linutronix.de> (raw)
In-Reply-To: <3ecb2012312c4af5bbd395391aa82921@BY2FFO11FD005.protection.gbl>
On 01/16/2015 12:02 PM, Michal Simek wrote:
>>> Origin patch looks good to me but this checking will be good to add.
>>> Are you using of_serial.c because I didn't find any of_alias_get_id call
>>> for 8250?
>>
>> I'm using of_alias_get_id() in 8250_omap.c which made it into
>> v3.19-rc1. I think the change you mention made it one release earlier.
>
> I see
> serial: of-serial: fetch line number from DT
> commit 1bd8324535ec1ff44aef55c0e40b9e7d56b310fb
>
> but it was reverted
>
> Revert "serial: of-serial: fetch line number from DT"
> commit e4c787dac21e50ac9ef53fac91b9182d4fede465
>
> Olof: what was the reason for that breakage?
> Is it missing alias list on Tegra?
> which caused that port->line number is bogus.
I doubt it, because a missing alias would return -1 and would not be
considered for port->line.
I think it is more what happens if you use the second UART and the
primary is unused (as in not probed). With this change the console will
be on ttyS1 - without it it remains on ttyS0. The former is what we
wanted.
And it seems they use for "nvidia,tegra[23]0-hsuart" the serial-tegra.c
driver which makes use of of_alias_get_id() but the of_serial() one
which is used by nvidia,tegra20-uart() does not. And since this change
does not notify anyone during upgrade but removes the console everyone
gets a little grumpy*.
* and I've been looking for a smooth solution for the ttyOx -> ttySx
change in OMAP just to avoid people complaining and risking a revert
:)
> Thanks,
> Michal
Sebastian
next prev parent reply other threads:[~2015-01-16 11:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 14:55 [PATCH 1/2] tty: serial: 8250_core: Remove trailing whitespaces Michal Simek
2015-01-15 14:55 ` [PATCH 2/2] tty: serial: 8250_core: Check that port->line is >=0 Michal Simek
2015-01-16 9:00 ` Sebastian Andrzej Siewior
2015-01-16 10:37 ` Michal Simek
2015-01-16 10:51 ` Sebastian Andrzej Siewior
2015-01-16 11:02 ` Michal Simek
2015-01-16 11:33 ` Sebastian Andrzej Siewior [this message]
2015-01-30 23:23 ` Greg Kroah-Hartman
2015-02-02 8:09 ` Michal Simek
2015-02-02 10:49 ` Andy Shevchenko
2015-01-30 23:22 ` [PATCH 1/2] tty: serial: 8250_core: Remove trailing whitespaces Greg Kroah-Hartman
2015-02-02 8:08 ` Michal Simek
2015-02-02 18:43 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B8F6F5.1030204@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mingo@elte.hu \
--cc=monstr@monstr.eu \
--cc=olof@lixom.net \
--cc=peter@hurleysoftware.com \
--cc=ricardo.ribalda@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).