From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754674AbbAZOEi (ORCPT ); Mon, 26 Jan 2015 09:04:38 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:37186 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753524AbbAZOEb (ORCPT ); Mon, 26 Jan 2015 09:04:31 -0500 Message-ID: <54C6494D.80802@roeck-us.net> Date: Mon, 26 Jan 2015 06:03:57 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Kirill A. Shutemov" CC: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org, sfr@canb.auug.org.au, mhocko@suse.cz, "Kirill A. Shutemov" Subject: Re: mmotm 2015-01-22-15-04: qemu failures due to 'mm: account pmd page tables to the process' References: <54c1822d.RtdGfWPekQVAw8Ly%akpm@linux-foundation.org> <20150123050445.GA22751@roeck-us.net> <20150123111304.GA5975@node.dhcp.inet.fi> <54C263CC.1060904@roeck-us.net> <20150123135519.9f1061caf875f41f89298d59@linux-foundation.org> <20150124055207.GA8926@roeck-us.net> <20150126122944.GE25833@node.dhcp.inet.fi> In-Reply-To: <20150126122944.GE25833@node.dhcp.inet.fi> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020205.54C6496F.013F,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 7 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/26/2015 04:29 AM, Kirill A. Shutemov wrote: > On Fri, Jan 23, 2015 at 09:52:07PM -0800, Guenter Roeck wrote: >> On Fri, Jan 23, 2015 at 01:55:19PM -0800, Andrew Morton wrote: >>> On Fri, 23 Jan 2015 07:07:56 -0800 Guenter Roeck wrote: >>> >>>>>> >>>>>> qemu:microblaze generates warnings to the console. >>>>>> >>>>>> WARNING: CPU: 0 PID: 32 at mm/mmap.c:2858 exit_mmap+0x184/0x1a4() >>>>>> >>>>>> with various call stacks. See >>>>>> http://server.roeck-us.net:8010/builders/qemu-microblaze-mmotm/builds/15/steps/qemubuildcommand/logs/stdio >>>>>> for details. >>>>> >>>>> Could you try patch below? Completely untested. >>>>> >>>>> >From b584bb8d493794f67484c0b57c161d61c02599bc Mon Sep 17 00:00:00 2001 >>>>> From: "Kirill A. Shutemov" >>>>> Date: Fri, 23 Jan 2015 13:08:26 +0200 >>>>> Subject: [PATCH] microblaze: define __PAGETABLE_PMD_FOLDED >>>>> >>>>> Microblaze uses custom implementation of PMD folding, but doesn't define >>>>> __PAGETABLE_PMD_FOLDED, which generic code expects to see. Let's fix it. >>>>> >>>>> Defining __PAGETABLE_PMD_FOLDED will drop out unused __pmd_alloc(). >>>>> It also fixes problems with recently-introduced pmd accounting. >>>>> >>>>> Signed-off-by: Kirill A. Shutemov >>>>> Reported-by: Guenter Roeck >>>> >>>> Tested working. >>>> >>>> Tested-by: Guenter Roeck >>>> >>>> Any idea how to fix the sh problem ? >>> >>> Can you tell us more about it? All I'm seeing is "qemu:sh fails to >>> shut down", which isn't very clear. >> >> Turns out that the include file defining __PAGETABLE_PMD_FOLDED >> was not always included where used, resulting in a messed up mm_struct. > > What means "messed up" here? It should only affect size of mm_struct. > Plus the offset of all variables after the #ifndef. >> The patch below fixes the problem for the sh architecture. >> No idea if the patch is correct/acceptable for other architectures. > > That's pain. Some archs includes from . > I don't see obvious way to fix this. Urghh. > Does it matter ? Circular includes are normally ok and happen all over the place. I could run a full build / qemu test cycle for all architectures if that helps. Guenter