From: Ian Abbott <abbotti@mev.co.uk>
To: Simon Guo <wei.guo.simon@gmail.com>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/02] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible
Date: Thu, 29 Jan 2015 12:26:12 +0000 [thread overview]
Message-ID: <54CA26E4.5020004@mev.co.uk> (raw)
In-Reply-To: <20150129053316.GA2508@thunderCat>
On 29/01/15 05:33, Simon Guo wrote:
> Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
> - code indent should use tabs where possible
> It is fixed by reformatting the comment block to usual comment style.
>
> And with the reformatting, following coding style problem is also fixed:
> - please, no space before tabs
>
> Signed-off-by: Simon Guo <wei.guo.simon@gmail.com>
> ---
> drivers/staging/comedi/drivers/pcl818.c | 189 +++++++++++++++-----------------
> 1 file changed, 91 insertions(+), 98 deletions(-)
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
prev parent reply other threads:[~2015-01-29 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 5:33 [PATCH v2 01/02] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible Simon Guo
2015-01-29 12:26 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CA26E4.5020004@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wei.guo.simon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).