linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Robert Rosengren <robert.rosengren@axis.com>,
	Jean Delvare <jdelvare@suse.de>
Cc: "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	Johan Adolfsson <johana@axis.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable
Date: Thu, 29 Jan 2015 06:10:27 -0800	[thread overview]
Message-ID: <54CA3F53.70107@roeck-us.net> (raw)
In-Reply-To: <54CA226E.6080505@axis.com>

On 01/29/2015 04:07 AM, Robert Rosengren wrote:
> On 01/29/2015 08:05 AM, Guenter Roeck wrote:
>> Ah, don't bother then. I should hopefully get the samples in a couple of days.
>
> i2cdump was easily built, so here is the output:
>       0,8  1,9  2,a  3,b  4,c  5,d  6,e  7,f
> 00: 1301 1301 1301 1301 1301 1301 1301 1301
> 08: 4101 6901 6a01 6901 6901 6901 6901 6901
> 10: 0200 0100 0100 0100 0100 0100 0100 0100
> 18: 0100 0100 0100 0100 0100 0100 0100 0100
> 20: 0200 0100 0100 0100 0100 0100 0100 0100
> 28: 0100 0100 0100 0100 0100 0100 0100 0100
> 30: 0200 0100 0100 0100 0100 0100 0100 0100
> 38: 0100 0100 0100 0100 0100 0100 0100 0100
> 40: 0000 0000 0000 0000 0000 0000 0000 0000
> 48: 0000 0000 0000 0000 0000 0000 0000 0000
> 50: 0200 0100 0100 0100 0100 0100 0100 0100
> 58: 0100 0100 0100 0100 0100 0100 0200 0100
> 60: 0100 0100 0100 0100 0100 0100 0100 0100
> 68: 0100 0100 0100 0100 0100 0100 0100 0100
> 70: 0200 0100 0100 0100 0100 0100 0100 0100
> 78: 0100 0100 0100 0100 0100 0100 0100 0100
> 80: 6501 2401 1701 1401 1301 1301 1301 1301
> 88: 4201 6901 6901 6901 6901 6901 6901 6901
> 90: 0200 0100 0100 0100 0100 0100 0100 0100
> 98: 0100 0100 0100 0100 0100 0100 0100 0100
> a0: 6701 2501 1901 1601 1501 1501 1501 1501
> a8: 4401 6c01 6c01 6c01 6c01 6c01 6c01 6c01
> b0: 0200 0100 0100 0100 0100 0100 0100 0100
> b8: 0100 0100 0100 0100 0100 0100 0100 0100
> c0: 0200 0100 0100 0100 0100 0100 0100 0100
> c8: 0100 0100 0100 0100 0100 0100 0100 0100
> d0: 0200 0100 0100 0100 0100 0100 0100 0100
> d8: 0100 0100 0100 0100 0100 0100 0100 0100
> e0: 6701 2801 1b01 1701 1601 1501 1501 1501
> e8: 4401 6c01 6c01 6c01 6c01 6c01 6c01 6c01
> f0: 0200 0100 0100 0100 0100 0100 0100 0100
> f8: 0100 0100 0100 0100 0100 0100 0100 0100
>
> I checked the value at 0x84 (channel 0, and using single-ended and external reference). I got 222 when reading from corresponding sysfs, and 0x131 * lsb_resolution (806) / 1000 is 222 in decimal. So it seems as data above is correct.
>
> Is the data what you expected?
>
Yes and no. With the above data, the old version of the driver
(non-regmap) works as expected. The driver supporting regmap,
however, needs the byte swap to work correctly.

Guenter


  reply	other threads:[~2015-01-29 14:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 12:05 [PATCH] hwmon: (ads7828) Make sample interval configurable Robert Rosengren
2015-01-16 14:52 ` Guenter Roeck
2015-01-16 18:30   ` [lm-sensors] " Guenter Roeck
2015-01-19 11:14     ` SV: " Robert Rosengren
2015-01-27  7:59     ` Robert Rosengren
2015-01-27 10:37       ` Jean Delvare
2015-01-27 14:23         ` Guenter Roeck
2015-01-27 14:07       ` Guenter Roeck
2015-01-27 19:54         ` Robert Rosengren
2015-01-27 20:05           ` Guenter Roeck
2015-01-27 22:34             ` Jean Delvare
2015-01-28  4:06               ` Guenter Roeck
     [not found]                 ` <54C87F3C.2020105@axis.com>
2015-01-28  6:28                   ` Robert Rosengren
2015-01-28 14:50                   ` Guenter Roeck
2015-01-29  7:00                     ` Robert Rosengren
2015-01-29  7:05                       ` Guenter Roeck
2015-01-29 12:07                         ` Robert Rosengren
2015-01-29 14:10                           ` Guenter Roeck [this message]
2015-01-29 19:30                           ` Guenter Roeck
2015-01-31 20:11                             ` Guenter Roeck
2015-02-02  8:12                               ` Robert Rosengren
2015-02-02 16:21                                 ` Guenter Roeck
2015-01-27 14:26       ` Guenter Roeck
2015-01-27 16:37       ` Guenter Roeck
2015-01-16 20:30 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CA3F53.70107@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.de \
    --cc=johana@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=robert.rosengren@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).