Re: [PATCH 1/2] x86: Add Isolated Memory Regions for Quark X1000

From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: "Ong, Boon Leong" <boon.leong.ong@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"dvhart@infradead.org" <dvhart@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 1/2] x86: Add Isolated Memory Regions for Quark X1000
Date: Thu, 29 Jan 2015 15:40:27 +0000	[thread overview]
Message-ID: <54CA546B.3040704@nexus-software.ie> (raw)
In-Reply-To: <AF233D1473C1364ABD51D28909A1B1B732715B43@PGSMSX105.gar.corp.intel.com>

On 29/01/15 15:32, Ong, Boon Leong wrote:
>
>
>> -----Original Message-----
>> From: Bryan O'Donoghue [mailto:pure.logic@nexus-software.ie]
>> Sent: Thursday, January 29, 2015 11:22 PM
>> To: Ong, Boon Leong
>> Cc: Thomas Gleixner; Ingo Molnar; H. Peter Anvin; x86@kernel.org;
>> dvhart@infradead.org; linux-kernel@vger.kernel.org; Andy Shevchenko; Ingo
>> Molnar
>> Subject: Re: [PATCH 1/2] x86: Add Isolated Memory Regions for Quark X1000
>>
>> On 29/01/15 13:47, Ong, Boon Leong wrote:
>>> Bryan,
>>>
>>> Once you have the next revision ready, I would like to test it on my end across
>> both Galileo Gen v1 & v2.
>>>
>>> Cheers,
>>> BL
>>
>> Andy/BL - thanks for taking the time to test.
>>
>> I may end up dropping the imr_del_range() tests based on index as a result of
>> changing the external interface as suggested by Ingo.
> It would be nice to have two variants (1) index based & (2) address based.

Understood. The direction from Ingo was to have address based external 
interface imr_del_range() and support an index based internal 
imr_clear() - internally.

So - in order to get test coverage - I'll move the self-test code back 
into the main IMR code

Not as pretty that way - but better coverage :)