From: Behan Webster <behanw@converseincode.com>
To: Arnd Bergmann <arnd@arndb.de>, David Miller <davem@davemloft.net>
Cc: sathya.perla@emulex.com, ajit.khaparde@emulex.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
subbu.seetharaman@emulex.com
Subject: Re: [PATCH] net, ethernet, LLVMLinux: Add missing MODULE_DEVICE_TABLE()
Date: Thu, 29 Jan 2015 10:21:01 -0800 [thread overview]
Message-ID: <54CA7A0D.8000104@converseincode.com> (raw)
In-Reply-To: <3392784.h8cmHX9fyr@wuerfel>
On 01/29/15 01:10, Arnd Bergmann wrote:
> On Wednesday 28 January 2015 22:42:28 David Miller wrote:
>> From: Behan Webster <behanw@converseincode.com>
>> Date: Wed, 28 Jan 2015 17:36:14 -0800
>>
>>> Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang.
>>>
>>> Signed-off-by: Behan Webster <behanw@converseincode.com>
>>> Suggested-by: Arnd Bergmann <arnd@arndb.de>
>> Why are you removing the device table?
> Behan took a patch that I did earlier and split it up to add descriptions.
> The patch is correct, but he either misunderstood or misexpressed the
> intention.
I was tired and rushed this submission in my preparation for FOSDEM.
Apologies to all.
I neglected to write the commit log when I first split the patch, and
didn't look hard enough this time.
> This driver has two identical lines that both say
>
> MODULE_DEVICE_TABLE(pci, be_dev_ids);
This is indeed the case.
> I don't remember the exact symptom, but llvm/clang trips over this, while gcc
> silently ignores the second one.
It claims that it is defined more than once.
Behan
--
Behan Webster
behanw@converseincode.com
next prev parent reply other threads:[~2015-01-29 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 1:36 [PATCH] net, ethernet, LLVMLinux: Add missing MODULE_DEVICE_TABLE() Behan Webster
2015-01-29 6:42 ` David Miller
2015-01-29 9:10 ` Arnd Bergmann
2015-01-29 11:29 ` Måns Rullgård
2015-01-29 18:21 ` Behan Webster [this message]
2015-01-29 18:25 ` Behan Webster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CA7A0D.8000104@converseincode.com \
--to=behanw@converseincode.com \
--cc=ajit.khaparde@emulex.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
--cc=subbu.seetharaman@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).