From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756371AbbA2SZP (ORCPT ); Thu, 29 Jan 2015 13:25:15 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:54773 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753716AbbA2SZN (ORCPT ); Thu, 29 Jan 2015 13:25:13 -0500 Message-ID: <54CA7B05.3000300@converseincode.com> Date: Thu, 29 Jan 2015 10:25:09 -0800 From: Behan Webster User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: David Miller CC: sathya.perla@emulex.com, ajit.khaparde@emulex.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, subbu.seetharaman@emulex.com, arnd@arndb.de Subject: Re: [PATCH] net, ethernet, LLVMLinux: Add missing MODULE_DEVICE_TABLE() References: <1422495374-22835-1-git-send-email-behanw@converseincode.com> <20150128.224228.1533046356464752424.davem@davemloft.net> In-Reply-To: <20150128.224228.1533046356464752424.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/28/15 22:42, David Miller wrote: > From: Behan Webster > Date: Wed, 28 Jan 2015 17:36:14 -0800 > >> Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang. >> >> Signed-off-by: Behan Webster >> Suggested-by: Arnd Bergmann > Why are you removing the device table? It is defined more than once; removing the duplicate (as Arnd indicated). My commit message was just completely wrong. Brain fart. Sorry. > Second of all, your Subject needs to be adjusted, using "net" and > "LLVMLinux" in your subsystem prefix is not appropriate. Simply > "be2net: ", the name of this driver, is sufficient. Will fix. I've been in the habit of labelling the patches which go through the LLVMLinux project like this so they are trivially identifiable in the subject on lkml for reviewers and in the git log as being patches which exist because of clang. If it's annoying I certainly don't need to do it. Behan -- Behan Webster behanw@converseincode.com