Re: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline

From: Randy Dunlap <rdunlap@infradead.org>
To: Borislav Petkov <bp@alien8.de>, Matt Fleming <matt@console-pimps.org>
Cc: Jon Masters <jonathan@jonmasters.org>,
	Laszlo Ersek <lersek@redhat.com>, Dave Young <dyoung@redhat.com>,
	linux-efi <linux-efi@vger.kernel.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Matt Fleming <matt.fleming@intel.com>,
	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline
Date: Fri, 30 Jan 2015 10:06:13 -0800	[thread overview]
Message-ID: <54CBC815.5060502@infradead.org> (raw)
In-Reply-To: <20150130164309.GG1451@pd.tnic>

On 01/30/15 08:43, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> Date: Mon, 26 Jan 2015 19:49:59 +0100
> Subject: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline
> 

Please update Documentation/kernel-parameters.txt also.

> ... and hide the memory regions dump behind it. Make it default-off.
> 
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Link: http://lkml.kernel.org/r/20141209095843.GA3990@pd.tnic
> ---
>  arch/x86/platform/efi/efi.c | 5 ++++-
>  include/linux/efi.h         | 1 +
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> index dbc8627a5cdf..e859d56ce9f8 100644
> --- a/arch/x86/platform/efi/efi.c
> +++ b/arch/x86/platform/efi/efi.c
> @@ -491,7 +491,8 @@ void __init efi_init(void)
>  	if (efi_memmap_init())
>  		return;
>  
> -	print_efi_memmap();
> +	if (efi_enabled(EFI_DBG))
> +		print_efi_memmap();
>  }
>  
>  void __init efi_late_init(void)
> @@ -939,6 +940,8 @@ static int __init arch_parse_efi_cmdline(char *str)
>  {
>  	if (parse_option_str(str, "old_map"))
>  		set_bit(EFI_OLD_MEMMAP, &efi.flags);
> +	if (parse_option_str(str, "debug"))
> +		set_bit(EFI_DBG, &efi.flags);
>  
>  	return 0;
>  }
> diff --git a/include/linux/efi.h b/include/linux/efi.h
> index 0238d612750e..14cec75d7e74 100644
> --- a/include/linux/efi.h
> +++ b/include/linux/efi.h
> @@ -940,6 +940,7 @@ extern int __init efi_setup_pcdp_console(char *);
>  #define EFI_64BIT		5	/* Is the firmware 64-bit? */
>  #define EFI_PARAVIRT		6	/* Access is via a paravirt interface */
>  #define EFI_ARCH_1		7	/* First arch-specific bit */
> +#define EFI_DBG			8	/* Print additional debug info at runtime */
>  
>  #ifdef CONFIG_EFI
>  /*
> 

-- 
~Randy