From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752525AbbAaMbS (ORCPT ); Sat, 31 Jan 2015 07:31:18 -0500 Received: from regular1.263xmail.com ([211.150.99.138]:57958 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751943AbbAaMbR (ORCPT ); Sat, 31 Jan 2015 07:31:17 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:S;ATT:S;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-MAE-MAIL_UID: 0054cccb04033d3c@maes@0d2f9619baaae737 X-MAE-ID: 223.6.254.61 X-RL-NAME: X-LOGIN-NAME: X-SENDER-IP: 121.15.173.1 Message-ID: <54CCCAF9.2050609@rock-chips.com> Date: Sat, 31 Jan 2015 07:30:49 -0500 From: Yang Kuankuan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Russell King - ARM Linux CC: David Airlie , Philipp Zabel , Fabio Estevam , Shawn Guo , Rob Clark , Mark Yao , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, djkurtz@chromium.org, dbehr@chromoum.org, mmind00@googlemail.com, dianders@chromium.org, marcheu@chromium.org, rockchip-discuss@chromium.org Subject: Re: [PATCH v2 04/12] drm: rockchip/dw_hdmi_rockchip: add resume/suspend support References: <1422617031-25098-1-git-send-email-ykk@rock-chips.com> <1422617339-25423-1-git-send-email-ykk@rock-chips.com> <20150131111351.GX26493@n2100.arm.linux.org.uk> In-Reply-To: <20150131111351.GX26493@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/31/2015 06:13 AM, Russell King - ARM Linux wrote: > On Fri, Jan 30, 2015 at 06:28:59AM -0500, Yakir Yang wrote: >> Signed-off-by: Yakir Yang >> --- >> Changes in v2: >> - Add suspend/resume support for dw_hdmi_rockchip driver >> >> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >> index d236faa..2f8bacb 100644 >> --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >> +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >> @@ -323,9 +323,22 @@ static int dw_hdmi_rockchip_remove(struct platform_device *pdev) >> return 0; >> } >> >> +static int dw_hdmi_rockchip_suspend(struct platform_device *pdev, >> + pm_message_t state) >> +{ >> + return dw_hdmi_suspend(pdev, state); >> +} >> + >> +static int dw_hdmi_rockchip_resume(struct platform_device *pdev) >> +{ >> + return dw_hdmi_resume(pdev); >> +} >> + >> static struct platform_driver dw_hdmi_rockchip_pltfm_driver = { >> .probe = dw_hdmi_rockchip_probe, >> .remove = dw_hdmi_rockchip_remove, >> + .resume = dw_hdmi_rockchip_resume, >> + .suspend = dw_hdmi_rockchip_suspend, >> .driver = { >> .name = "dwhdmi-rockchip", >> .of_match_table = dw_hdmi_rockchip_dt_ids, > Using the power management operations (setting the .pm member in > the embedded struct device_driver) is preferred over using the > .resume and .suspend methods. > > Please update this patch to use the preferred method. Thanks. > Okay, I will fixed it in next version v3. Thanks. : )