From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932778AbbBBHfA (ORCPT ); Mon, 2 Feb 2015 02:35:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40705 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932245AbbBBHez (ORCPT ); Mon, 2 Feb 2015 02:34:55 -0500 Message-ID: <54CF2800.5070608@redhat.com> Date: Mon, 02 Feb 2015 15:32:16 +0800 From: Baoquan He User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Thomas Gleixner CC: linux-kernel@vger.kernel.org, mingo@redhat.com, x86@kernel.org, vgoyal@redhat.com, keescook@chromium.org, ak@linux.intel.com, ebiederm@xmission.com, kexec@lists.infradead.org, whissi@whissi.de, kumagai-atsushi@mxc.nes.nec.co.jp, hpa@zytor.com Subject: Re: [resend Patch v3 2/2] export the kernel image size KERNEL_IMAGE_SIZE References: <1412060896-1902-1-git-send-email-bhe@redhat.com> <1412060896-1902-2-git-send-email-bhe@redhat.com> In-Reply-To: <1412060896-1902-2-git-send-email-bhe@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, Could you please also merge this patch? Since you have merged this patch "x86, boot: Skip relocs when load address unchanged [commit f285f4a21]", and this issue was raised because it broke kexec/kdump, then I posted these 2 patches. Without this patch makedumpfile will be broken when enable kaslr and do the kdump. Thanks Baouqan On 09/30/2014 03:08 PM, Baoquan He wrote: > Now kaslr makes kernel image size changable, not the fixed size 512M. > So KERNEL_IMAGE_SIZE need be exported to VMCOREINFO, otherwise makedumfile > will crash. > > Signed-off-by: Baoquan He > Acked-by: Kees Cook > Acked-by: Vivek Goyal > --- > kernel/kexec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 2bee072..bd680d3 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -2003,6 +2003,9 @@ static int __init crash_save_vmcoreinfo_init(void) > #endif > VMCOREINFO_NUMBER(PG_head_mask); > VMCOREINFO_NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE); > +#ifdef CONFIG_X86 > + VMCOREINFO_NUMBER(KERNEL_IMAGE_SIZE); > +#endif > #ifdef CONFIG_HUGETLBFS > VMCOREINFO_SYMBOL(free_huge_page); > #endif >