From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932799AbbBBHzr (ORCPT ); Mon, 2 Feb 2015 02:55:47 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:42589 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932551AbbBBHzn (ORCPT ); Mon, 2 Feb 2015 02:55:43 -0500 Message-ID: <54CF2D36.5060002@st.com> Date: Mon, 2 Feb 2015 08:54:30 +0100 From: Patrice Chotard User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Chen Gang S , , , Cc: "linux-arm-kernel@lists.infradead.org" , , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] rc: st_rc: Use CONFIG_PM_SLEEP instead of CONFIG_PM for st_rc_suspend() and st_rc_resume() References: <54CE3B47.6050909@sunrus.com.cn> In-Reply-To: <54CE3B47.6050909@sunrus.com.cn> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.254.1] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-02-02_01:2015-01-30,2015-02-01,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chen On 02/01/2015 03:42 PM, Chen Gang S wrote: > st_rc_suspend() and st_rc_resume() depend on CONFIG_PM_SLEEP finally, so > they need CONFIG_PM_SLEEP instead of CONFIG_PM, or they will cause build > warning (with allmodconfig under xtensa): > > CC [M] drivers/media/pci/smipcie/smipcie.o > drivers/media/rc/st_rc.c:338:12: warning: 'st_rc_suspend' defined but not used [-Wunused-function] > static int st_rc_suspend(struct device *dev) > ^ > drivers/media/rc/st_rc.c:359:12: warning: 'st_rc_resume' defined but not used [-Wunused-function] > static int st_rc_resume(struct device *dev) > ^ > > Signed-off-by: Chen Gang > --- > drivers/media/rc/st_rc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c > index 0e758ae..fbfe958 100644 > --- a/drivers/media/rc/st_rc.c > +++ b/drivers/media/rc/st_rc.c > @@ -334,7 +334,7 @@ err: > return ret; > } > > -#ifdef CONFIG_PM > +#ifdef CONFIG_PM_SLEEP > static int st_rc_suspend(struct device *dev) > { > struct st_rc_device *rc_dev = dev_get_drvdata(dev); Acked-by: Patrice Chotard Thanks