From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932946AbbBBINE (ORCPT ); Mon, 2 Feb 2015 03:13:04 -0500 Received: from bes.se.axis.com ([195.60.68.10]:35740 "EHLO bes.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932551AbbBBINA (ORCPT ); Mon, 2 Feb 2015 03:13:00 -0500 Message-ID: <54CF3189.8050504@axis.com> Date: Mon, 2 Feb 2015 09:12:57 +0100 From: Robert Rosengren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Guenter Roeck CC: Johan Adolfsson , "linux-kernel@vger.kernel.org" , "lm-sensors@lm-sensors.org" Subject: Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable References: <54C79B87.8040607@roeck-us.net> <4BEA3FF3CAA35E408EA55C7BE2E61D05943B6DD753@xmail3.se.axis.com> <20150127200553.GA5689@roeck-us.net> <20150127233455.0c62457e@endymion.delvare> <54C86035.9080605@roeck-us.net> <54C87F3C.2020105@axis.com> <54C8F73D.4040808@roeck-us.net> <54C9DA9D.3010802@axis.com> <54C9DBD5.5030808@roeck-us.net> <54CA226E.6080505@axis.com> <20150129193040.GA21937@roeck-us.net> <54CD36DF.7010602@roeck-us.net> In-Reply-To: <54CD36DF.7010602@roeck-us.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/31/2015 09:11 PM, Guenter Roeck wrote: > On 01/29/2015 11:30 AM, Guenter Roeck wrote: >> On Thu, Jan 29, 2015 at 01:07:10PM +0100, Robert Rosengren wrote: >>>> Is your hardware big endian or little endian ? >>> CONFIG_CPU_LITTLE_ENDIAN=y >>> >> Hi Robert, >> >> I have another question: What is your i2c controller type ? >> > Robert, > > I now tried both 3.15 and 3.19-rc6. Both kernels require the byte swap code. Agrees, no difference for me when trying with 3.15 and 3.18 version. The i2c is a bit-bang driver, specific for the hardware I am running on. > > The only reason I can imagine why you don't need it in your code would be > that your i2c controller does not support i2c functionality but only SMBus. > This would be the case, for example, with the i801 controller. So it would > be quite helpful to know which controller your system uses to access the > ads7828. > > Thanks, > Guenter > I tried your latest patch set (the 3 patches submitted last night) and it works fine for me. Great work! Please change my Cc-tag in the patches to Reviewed-by or Tested-by (I have done both, but one tag is enough). Thanks :-) BR, Robert