From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933174AbbBBKZh (ORCPT ); Mon, 2 Feb 2015 05:25:37 -0500 Received: from mout.web.de ([212.227.15.4]:56814 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932911AbbBBKZf (ORCPT ); Mon, 2 Feb 2015 05:25:35 -0500 Message-ID: <54CF509A.2000801@users.sourceforge.net> Date: Mon, 02 Feb 2015 11:25:30 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "David S. Miller" , Paul Moore , netdev@vger.kernel.org CC: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH v3 1/3] netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_putdef" References: <54CD4B5F.9010502@users.sourceforge.net> <54CDFCDA.9010802@users.sourceforge.net> <20150201.123054.366525761630045391.davem@davemloft.net> <54CF4FEC.2010906@users.sourceforge.net> In-Reply-To: <54CF4FEC.2010906@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:euuomBsIBJrMwdbd3KSyP8TLuvC7+mbVRYkXKl8WUowgJ4De4g0 Ugbp296FbYR6vzFsd0idWao1HdYlm26pPiKfpnHCdS65PHpX8xUy/ReXxUReLV3ZS8bsHZ9 P18EpPiz5DF5K0MQ3BzuQkJRD1m3Ng3641CCcCW+QtIqX5mwymP+Qyx2bU9z6YEL6Wc0fqk U8SxKfjk3WovjeFqFedMQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 2 Feb 2015 10:01:45 +0100 The cipso_v4_doi_putdef() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Paul Moore --- net/netlabel/netlabel_mgmt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/netlabel/netlabel_mgmt.c b/net/netlabel/netlabel_mgmt.c index 8b3b789..f5807f5 100644 --- a/net/netlabel/netlabel_mgmt.c +++ b/net/netlabel/netlabel_mgmt.c @@ -242,8 +242,7 @@ static int netlbl_mgmt_add_common(struct genl_info *info, return 0; add_failure: - if (cipsov4) - cipso_v4_doi_putdef(cipsov4); + cipso_v4_doi_putdef(cipsov4); if (entry) kfree(entry->domain); kfree(addrmap); -- 2.2.2