From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933830AbbBCK6j (ORCPT ); Tue, 3 Feb 2015 05:58:39 -0500 Received: from mout.web.de ([212.227.17.12]:56274 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753451AbbBCK6g (ORCPT ); Tue, 3 Feb 2015 05:58:36 -0500 Message-ID: <54D0A9D5.6020603@users.sourceforge.net> Date: Tue, 03 Feb 2015 11:58:29 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Thierry Reding , linux-pwm@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] pwm: Delete an unnecessary check before the function call "of_node_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:JBZY7VI9IuUEHm+WGcQu/f6qMAtZrHPxqR7YEyCPxP6ZRj1a0gb H0MoF0zYv/fCeZY3JD0NsrfVHBWooT/z/etuHYytU1jxamtwbWsaAVduUnHIEHca90Md8x7 1rrVwtmnjE1ZcFe/wYztcRryN2VSdZyA2cUNJnVVfAVaul8f4xICE9Dt/2j+rMxFLv7Hx3t Ts2tlM0VTWejMeySc3F5A== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 3 Feb 2015 11:54:28 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pwm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 966497d..810aef3 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -192,7 +192,7 @@ static void of_pwmchip_add(struct pwm_chip *chip) static void of_pwmchip_remove(struct pwm_chip *chip) { - if (chip->dev && chip->dev->of_node) + if (chip->dev) of_node_put(chip->dev->of_node); } -- 2.2.2