From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933943AbbBCMpE (ORCPT ); Tue, 3 Feb 2015 07:45:04 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:58876 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751867AbbBCMpB (ORCPT ); Tue, 3 Feb 2015 07:45:01 -0500 X-AuditID: cbfee68e-f79b46d000002b74-46-54d0c2ca2d50 Message-id: <54D0C2CA.3040606@samsung.com> Date: Tue, 03 Feb 2015 21:44:58 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Sylwester Nawrocki Cc: tomasz.figa@gmail.com, mturquette@linaro.org, kgene@kernel.org, pankaj.dubey@samsung.com, sangbae90.lee@samsung.com, inki.dae@samsung.com, chanho61.park@samsung.com, sw0312.kim@samsung.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 08/13] clk: samsung: exynos5433: Add clocks for CMU_DISP domain References: <1422887047-30911-1-git-send-email-cw00.choi@samsung.com> <1422887047-30911-9-git-send-email-cw00.choi@samsung.com> <54D0BC6C.9020008@samsung.com> <54D0BF29.9060002@samsung.com> In-reply-to: <54D0BF29.9060002@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsWyRsSkSPfUoQshBpv3q1pc3q9tMf/IOVaL SfcnsFj0P37NbHF51xw2ixnn9zFZPJ1wkc1i0dYv7BaH37SzWhz/dJDFYsbkl2wWq3b9YXTg 8dg56y67x6ZVnWwed67tYfPo27KK0ePzJrkA1igum5TUnMyy1CJ9uwSujNWTPjMXnBCuOHf1 H3MD43KBLkZODgkBE4kXWw8zQ9hiEhfurWfrYuTiEBJYyijx+9ZpRpiib8vuMEEkFjFKnJlw hQXCec0o8eP8IlaQKl4BLYm/346wgdgsAqoSi3fvButmA4rvf3EDLC4qECaxcjpIM0i9oMSP yffAbBEBfYklqy6CrWYWWMok0d40mx0kISwQIfFn0zF2iG0HGSWmb+0Fm8QpoC2xbvdSoM0c QB16EvcvaoGEmQXkJTavecsMUi8h8JVdovlvLyPERQIS3yYfYgGplxCQldh0AOpnSYmDK26w TGAUm4XkplkIU2chmbqAkXkVo2hqQXJBcVJ6kZFecWJucWleul5yfu4mRmCknv73rG8H480D 1ocYBTgYlXh4Z6hcCBFiTSwrrsw9xGgKdMREZinR5HxgOsgriTc0NjOyMDUxNTYytzRTEudN kPoZLCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoFRp6XzOluGvvC5ynO5H6YecDOJD7R2MLzf 8H/CX8ua0hmmu/vOuXiF215m7V/xvO/QKdHTX3z3/bvvfuHt/TNb7L5n8BxU+65+90DTeUZT S0270ID+1yuOtPIubTnjZs1y4YF9+vXnUgnrprpzPt5zZkVLnUbEjBDZovaJTb5M3yKvu7ad 9clXYinOSDTUYi4qTgQA3At3Vs8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjleLIzCtJLcpLzFFi42I5/e+xgO6pQxdCDHYslbG4vF/bYv6Rc6wW k+5PYLHof/ya2eLyrjlsFjPO72OyeDrhIpvFoq1f2C0Ov2lntTj+6SCLxYzJL9ksVu36w+jA 47Fz1l12j02rOtk87lzbw+bRt2UVo8fnTXIBrFENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7x pmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QPcpKZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUN CYLrMTJAAwlrGDNWT/rMXHBCuOLc1X/MDYzLBboYOTkkBEwkvi27wwRhi0lcuLeerYuRi0NI YBGjxJkJV1ggnNeMEj/OL2IFqeIV0JL4++0IG4jNIqAqsXj3bkYQmw0ovv/FDbC4qECYxMrp IM0g9YISPybfA7NFBPQllqy6CLaBWWApk0R702x2kISwQITEn03H2CG2HWSUmL61F2wSp4C2 xLrdS4E2cwB16Encv6gFEmYWkJfYvOYt8wRGgVlIdsxCqJqFpGoBI/MqRtHUguSC4qT0XCO9 4sTc4tK8dL3k/NxNjOA08Ex6B+OqBotDjAIcjEo8vDNULoQIsSaWFVfmHmKU4GBWEuFNXw4U 4k1JrKxKLcqPLyrNSS0+xGgKDIGJzFKiyfnAFJVXEm9obGJmZGlkbmhhZGyuJM6rZN8WIiSQ nliSmp2aWpBaBNPHxMEp1cBYuM9hnfS7redb2dp2WnZ47VvyrGoyY5SS6g0tV5aWTX8/7nL5 EZi/MyUt0TPiU8JT2dNfnPrPxh34Ib9DgvvUxDLOmUsUZZer+vC0rnjVLeMQ7mLuK3Ej8HUh 94Vcxq/NW+cfu7w14sM/9itPBdlnT9kQmbq59/6WO1u3L3Bk/r5157YHZiLFSizFGYmGWsxF xYkAwBcG8RkDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sylwester, On 02/03/2015 09:29 PM, Sylwester Nawrocki wrote: > On 03/02/15 13:17, Sylwester Nawrocki wrote: >>> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c >>>> index 3d6164e..cf3f0ac 100644 >>>> --- a/drivers/clk/samsung/clk-exynos5433.c >>>> +++ b/drivers/clk/samsung/clk-exynos5433.c >>>> @@ -245,6 +245,8 @@ PNAME(mout_sclk_audio1_p) = { "ioclk_audiocdclk1", "oscclk", >>>> PNAME(mout_sclk_audio0_p) = { "ioclk_audiocdclk0", "oscclk", >>>> "mout_aud_pll_user_t",}; >>>> >>>> +PNAME(mout_sclk_hdmi_spdif_p) = { "sclk_audio1", "ioclk_spdif_extclk", }; >>>> + >>>> static struct samsung_fixed_factor_clock top_fixed_factor_clks[] __initdata = { >>>> FFACTOR(0, "oscclk_efuse_common", "oscclk", 1, 1, 0), >>>> }; >>>> @@ -395,6 +397,10 @@ static struct samsung_mux_clock top_mux_clks[] __initdata = { >>>> MUX_SEL_TOP_PERIC1, 4, 2), >>>> MUX(CLK_MOUT_SCLK_AUDIO0, "mout_sclk_audio0", mout_sclk_audio0_p, >>>> MUX_SEL_TOP_PERIC1, 0, 2), >>>> + >>>> + /* MUX_SEL_TOP_DISP */ >>>> + MUX(CLK_MOUT_SCLK_HDMI_SPDIF, "mout_sclk_hdmi_spdif", >>>> + mout_sclk_hdmi_spdif_p, MUX_SEL_TOP_DISP, 0, 1), >>>> }; >>>> >>>> static struct samsung_div_clock top_div_clks[] __initdata = { >>>> @@ -1360,6 +1366,11 @@ static struct samsung_gate_clock mif_gate_clks[] __initdata = { >>>> ENABLE_SCLK_MIF, 1, CLK_IGNORE_UNUSED, 0), >>>> GATE(CLK_SCLK_BUS_PLL_ATLAS, "sclk_bus_pll_atlas", "sclk_bus_pll", >>>> ENABLE_SCLK_MIF, 0, CLK_IGNORE_UNUSED, 0), >>>> + >>>> + /* ENABLE_SCLK_TOP_DISP */ >>>> + GATE(CLK_SCLK_HDMI_SPDIF_DISP, "sclk_hdmi_spdif_disp", >>>> + "mout_sclk_hdmi_spdif", ENABLE_SCLK_TOP_DISP, 0, >>>> + CLK_IGNORE_UNUSED, 0), >> >> I think this clock should be added to top_gate_clks[] table instead, i.e. >> it seems to belong to CMU_TOP, not CMU_MIF. Can you double check it ? You're right. The sclk_hdmi_spdif_disp should be included in CMU_TOP domain. >> >> If you confirm this I will add following change when applying, no need >> to resend again: > > I'm afraid you will need to resend if that change turns out to be > needed, since the whole CMU_TOP clock indexing would need to be changed > then :/. Or just send a fixup patch on top of both series, adding > CLK_SCLK_HDMI_SPDIF_DISP as last CMU_TOP clk index. If you ok, I'll just send fix patch on top of both series as your comment. (adding CLK_SCLK_HDMI_SPDIF_DISP). Thanks, Chanwoo Choi