From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966327AbbBCSkR (ORCPT ); Tue, 3 Feb 2015 13:40:17 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:49574 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965698AbbBCSkN (ORCPT ); Tue, 3 Feb 2015 13:40:13 -0500 Message-ID: <54D11608.2070408@imgtec.com> Date: Tue, 3 Feb 2015 10:40:08 -0800 From: Leonid Yegoshin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Guenter Roeck , Ralf Baechle CC: , , "Atsushi Nemoto" , Matthew Wilcox Subject: Re: mips: Re-introduce copy_user_page References: <1422681807-28395-1-git-send-email-linux@roeck-us.net> In-Reply-To: <1422681807-28395-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.65.146] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/30/2015 09:23 PM, Guenter Roeck wrote: > Commit bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") replaced > the inline function copy_user_page for mips with an external reference, > but neglected to introduce the actual non-inline function. Restore it. > > Fixes: bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") > Fixes: 4927b7d77c00 ("dax,ext2: replace the XIP page fault handler with the DAX page fault handler") > Cc: Atsushi Nemoto > Cc: Matthew Wilcox > Signed-off-by: Guenter Roeck > Why do you use copy_user_page? It doesn't work properly in HIGHMEM environment and it is excluded from MIPS because of that, I believe. You should use copy_user_highpage() for user pages. - Leonid.