From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753971AbbBDDR3 (ORCPT ); Tue, 3 Feb 2015 22:17:29 -0500 Received: from mail7.hitachi.co.jp ([133.145.228.42]:46174 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753765AbbBDDR2 (ORCPT ); Tue, 3 Feb 2015 22:17:28 -0500 Message-ID: <54D18F41.4070207@hitachi.com> Date: Wed, 04 Feb 2015 12:17:21 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Wang Long Cc: davem@davemloft.net, anil.s.keshavamurthy@intel.com, ananth@in.ibm.com, linux-kernel@vger.kernel.org, peifeiyue@huawei.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] SAMPLES: kprobe_example: Make it print something on ARM. References: <1423018585-4005-1-git-send-email-long.wanglong@huawei.com> In-Reply-To: <1423018585-4005-1-git-send-email-long.wanglong@huawei.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2015/02/04 11:56), Wang Long wrote: > This KProbes example is a little useless if it doesn't print anything. > For ARM print similar messages to those produced on x86 and PPC. BTW, I guess similar update required for s390, doesn't it? > > Signed-off-by: Wang Long Acked-by: Masami Hiramatsu Thank you! > --- > samples/kprobes/kprobe_example.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c > index 366db1a..eba9f1a 100644 > --- a/samples/kprobes/kprobe_example.c > +++ b/samples/kprobes/kprobe_example.c > @@ -42,6 +42,11 @@ static int handler_pre(struct kprobe *p, struct pt_regs *regs) > " ex1 = 0x%lx\n", > p->addr, regs->pc, regs->ex1); > #endif > +#ifdef CONFIG_ARM > + printk(KERN_INFO "pre_handler: p->addr = 0x%p, ARM_pc = 0x%lx," > + " ARM_cpsr = 0x%lx\n", > + p->addr, regs->ARM_pc, regs->ARM_cpsr); > +#endif > > /* A dump_stack() here will give a stack backtrace */ > return 0; > @@ -67,6 +72,10 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs, > printk(KERN_INFO "post_handler: p->addr = 0x%p, ex1 = 0x%lx\n", > p->addr, regs->ex1); > #endif > +#ifdef CONFIG_ARM > + printk(KERN_INFO "post_handler: p->addr = 0x%p, ARM_cpsr = 0x%lx\n", > + p->addr, regs->ARM_cpsr); > +#endif > } > > /* > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com