From: Guenter Roeck <linux@roeck-us.net>
To: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>,
Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
Matthew Wilcox <matthew.r.wilcox@intel.com>
Subject: Re: mips: Re-introduce copy_user_page
Date: Tue, 03 Feb 2015 19:33:02 -0800 [thread overview]
Message-ID: <54D192EE.6070302@roeck-us.net> (raw)
In-Reply-To: <54D11608.2070408@imgtec.com>
On 02/03/2015 10:40 AM, Leonid Yegoshin wrote:
> On 01/30/2015 09:23 PM, Guenter Roeck wrote:
>> Commit bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") replaced
>> the inline function copy_user_page for mips with an external reference,
>> but neglected to introduce the actual non-inline function. Restore it.
>>
>> Fixes: bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork")
>> Fixes: 4927b7d77c00 ("dax,ext2: replace the XIP page fault handler with the DAX page fault handler")
>> Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
>> Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>
> Why do you use copy_user_page?
> It doesn't work properly in HIGHMEM environment and it is excluded from MIPS because of that, I believe.
>
> You should use copy_user_highpage() for user pages.
>
Then maybe mips should not declare it the function external, the commit log
of the patch removing it should have mentioned that and why it was removed,
and there should be a clear statement somewhere stating that copy_user_page
shall not be used. I don't find such a statement anywhere in the kernel.
Guenter
next prev parent reply other threads:[~2015-02-04 3:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 5:23 [PATCH] mips: Re-introduce copy_user_page Guenter Roeck
2015-02-03 18:40 ` Leonid Yegoshin
2015-02-04 3:33 ` Guenter Roeck [this message]
2015-02-04 16:25 ` Wilcox, Matthew R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D192EE.6070302@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Leonid.Yegoshin@imgtec.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matthew.r.wilcox@intel.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).