From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965145AbbBDJy0 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Feb 2015 04:54:26 -0500
Received: from mout.web.de ([212.227.17.11]:51377 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752102AbbBDJyW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Feb 2015 04:54:22 -0500
Message-ID: <54D1EC46.1020201@users.sourceforge.net>
Date: Wed, 04 Feb 2015 10:54:14 +0100
From: SF Markus Elfring <elfring@users.sourceforge.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: David Miller <davem@davemloft.net>
CC: Jamal Hadi Salim <jhs@mojatatu.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] net: sched: One function call less in em_meta_change()
 after error detection
References: <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>	<5317A59D.4@users.sourceforge.net>	<54CD042E.6030606@users.sourceforge.net> <20150203.161054.379086029122558267.davem@davemloft.net>
In-Reply-To: <20150203.161054.379086029122558267.davem@davemloft.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:so7Y9ceU57I6DtkR9LsdGE8hdMuotEnRd7uPb10qHKz6qWBpARm
 0lkoE/3TFKGodQgR/5nc+RipCUUXDjZq6uj3HJHz6x2guFu/tjI2jruNNL82VKDAx2o+qT+
 mAWhxXpJrvJO3Dbwilo0f9gIZD9AOeDd3Joz1+Sm/Wg1NIyxwkuFssHuPi3nZhEamJoFF3G
 R/X8BLBoBqFWgaSURKAmQ==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> The meta_delete() function could be called in four cases by the
>> em_meta_change() function during error handling even if the passed
>> variable "meta" contained still a null pointer.
>>
>> * This implementation detail could be improved by adjustments for jump labels.
>>
>> * Let us return immediately after the first failed function call according to
>>   the current Linux coding style convention.
>>
>> * Let us delete also unnecessary checks for the variables "err" and
>>   "meta" there.
> 
> I kind of like the way the code is now, branching to the end of the function
> even when cleanups are not necessary.

I would appreciate if the affected exception handling can become also
a bit more efficient.

Regards,
Markus