From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934000AbbBDNbh (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Feb 2015 08:31:37 -0500
Received: from mail-la0-f44.google.com ([209.85.215.44]:52606 "EHLO
	mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933347AbbBDNbd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Feb 2015 08:31:33 -0500
Message-ID: <54D21F31.5080706@cogentembedded.com>
Date: Wed, 04 Feb 2015 16:31:29 +0300
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Organization: Cogent Embedded
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Geert Uytterhoeven <geert+renesas@glider.be>,
        Mike Turquette <mturquette@linaro.org>,
        Stephen Boyd <sboyd@codeaurora.org>
CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Ulrich Hecht <ulrich.hecht+renesas@gmail.com>,
        Wolfram Sang <wsa@sang-engineering.com>, linux-sh@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()
References: <1423052841-15194-1-git-send-email-geert+renesas@glider.be>
In-Reply-To: <1423052841-15194-1-git-send-email-geert+renesas@glider.be>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 02/04/2015 03:27 PM, Geert Uytterhoeven wrote:

> Anyone may call clk_round_rate() with a zero rate value, so we have to
> protect against that.

    Shouldn't this be checked and fixed up in clk_round_rate() then?

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

WBR, Sergei