From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161952AbbBDTzD (ORCPT ); Wed, 4 Feb 2015 14:55:03 -0500 Received: from mout.web.de ([212.227.17.11]:54838 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161898AbbBDTyz (ORCPT ); Wed, 4 Feb 2015 14:54:55 -0500 Message-ID: <54D27906.9070507@users.sourceforge.net> Date: Wed, 04 Feb 2015 20:54:46 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Cliff Whickman , Robin Holt CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] SGI-XPC: Delete an unnecessary check before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:dSImtInhGDfnYiqu7dzwReFXjprqeAT3U6gEKjCG4hsHFlfex2S 5EWq8xkWhfTjd3+PBi5D+KCdM7mh3fEGR428POvAmRNTS7wxO3/lKQE1nwPlX9cKOyR4FeZ li8DtBs4Qz2ovf/9M4obWA1Gh33Rp2Nmj5fIaIPRu/wttvih2TlrIg8kLGHUW2LKJvl5Po/ fx5pJ5u0UCli++8JmgDFg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 4 Feb 2015 20:50:31 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/sgi-xp/xpc_partition.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/sgi-xp/xpc_partition.c b/drivers/misc/sgi-xp/xpc_partition.c index 6956f7e..0e32431 100644 --- a/drivers/misc/sgi-xp/xpc_partition.c +++ b/drivers/misc/sgi-xp/xpc_partition.c @@ -98,8 +98,7 @@ xpc_get_rsvd_page_pa(int nasid) len = L1_CACHE_ALIGN(len); if (len > buf_len) { - if (buf_base != NULL) - kfree(buf_base); + kfree(buf_base); buf_len = L1_CACHE_ALIGN(len); buf = xpc_kmalloc_cacheline_aligned(buf_len, GFP_KERNEL, &buf_base); -- 2.2.2