From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161646AbbBDUgQ (ORCPT ); Wed, 4 Feb 2015 15:36:16 -0500 Received: from mout.web.de ([212.227.17.11]:54850 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161501AbbBDUgK (ORCPT ); Wed, 4 Feb 2015 15:36:10 -0500 Message-ID: <54D282B0.90907@users.sourceforge.net> Date: Wed, 04 Feb 2015 21:36:00 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] macintosh: Delete an unnecessary check before the function call "of_node_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:wKfXwQJu8jxKHz6EUunXE5EetkCQh9AwrqWt6ez0nbCW4oR9Ym6 2mJddWJvwP8U9cPP+cs8JWPQj2xBwcd9L1A8yhzeGvyknWTPYTNIXXo0lbbxsyQa/kbyA/6 VXM6aQFDC/JwZWkQyOgebORjTY44mqWEshYO14cmBwLoXfcuxKw0C1pyDCr/wZ117ewfkIP I60T8+Sql5i7lEXGX1UhQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 4 Feb 2015 21:32:27 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/macintosh/smu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c index 10ae69b..d531f80 100644 --- a/drivers/macintosh/smu.c +++ b/drivers/macintosh/smu.c @@ -557,8 +557,7 @@ int __init smu_init (void) return 0; fail_msg_node: - if (smu->msg_node) - of_node_put(smu->msg_node); + of_node_put(smu->msg_node); fail_db_node: of_node_put(smu->db_node); fail_bootmem: -- 2.2.2