From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756283AbbBEBKq (ORCPT ); Wed, 4 Feb 2015 20:10:46 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:9408 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752084AbbBEBKp (ORCPT ); Wed, 4 Feb 2015 20:10:45 -0500 Message-ID: <54D2C2CA.7070705@huawei.com> Date: Thu, 5 Feb 2015 09:09:30 +0800 From: "long.wanglong" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Masami Hiramatsu CC: , , , , , Subject: Re: [PATCH] SAMPLES: kprobe_example: Make it print something on ARM. References: <1423018585-4005-1-git-send-email-long.wanglong@huawei.com> <54D18F41.4070207@hitachi.com> In-Reply-To: <54D18F41.4070207@hitachi.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.88.174] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/2/4 11:17, Masami Hiramatsu wrote: > (2015/02/04 11:56), Wang Long wrote: >> This KProbes example is a little useless if it doesn't print anything. >> For ARM print similar messages to those produced on x86 and PPC. > > BTW, I guess similar update required for s390, doesn't it? > yes, because i am not familiar with s390, someone else may update this example for s390. Best Regards Wang Long >> >> Signed-off-by: Wang Long > > Acked-by: Masami Hiramatsu > > Thank you! > >> --- >> samples/kprobes/kprobe_example.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c >> index 366db1a..eba9f1a 100644 >> --- a/samples/kprobes/kprobe_example.c >> +++ b/samples/kprobes/kprobe_example.c >> @@ -42,6 +42,11 @@ static int handler_pre(struct kprobe *p, struct pt_regs *regs) >> " ex1 = 0x%lx\n", >> p->addr, regs->pc, regs->ex1); >> #endif >> +#ifdef CONFIG_ARM >> + printk(KERN_INFO "pre_handler: p->addr = 0x%p, ARM_pc = 0x%lx," >> + " ARM_cpsr = 0x%lx\n", >> + p->addr, regs->ARM_pc, regs->ARM_cpsr); >> +#endif >> >> /* A dump_stack() here will give a stack backtrace */ >> return 0; >> @@ -67,6 +72,10 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs, >> printk(KERN_INFO "post_handler: p->addr = 0x%p, ex1 = 0x%lx\n", >> p->addr, regs->ex1); >> #endif >> +#ifdef CONFIG_ARM >> + printk(KERN_INFO "post_handler: p->addr = 0x%p, ARM_cpsr = 0x%lx\n", >> + p->addr, regs->ARM_cpsr); >> +#endif >> } >> >> /* >> > >