From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756915AbbBEI3E (ORCPT ); Thu, 5 Feb 2015 03:29:04 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:24245 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756418AbbBEI27 (ORCPT ); Thu, 5 Feb 2015 03:28:59 -0500 X-AuditID: cbfee68d-f79296d000004278-dd-54d329c82017 Message-id: <54D329D0.7050006@samsung.com> Date: Thu, 05 Feb 2015 17:29:04 +0900 From: Joonyoung Shim User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-version: 1.0 To: SF Markus Elfring , David Airlie , Inki Dae , Jingoo Han , Kukjin Kim , Kyungmin Park , Seung-Woo Kim , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH] GPU-DRM-Exynos: Delete unnecessary checks before two function calls References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54D28870.3060400@users.sourceforge.net> In-reply-to: <54D28870.3060400@users.sourceforge.net> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsWyRsSkUPeE5uUQg0nT1Sx6z51ksrjy9T2b xfnO5cwWk+5PYLG4vPASq8WyB6cZLbbekrbof/ya2eJs0xt2i02Pr7FaXN41h81ixvl9TBYz Jr9kc+D12LSqk81j+7cHrB57t2R53O8+zuSxeUm9R9+WVYweTafaWT0+b5IL4IjisklJzcks Sy3St0vgyri2up2t4Bt/xbm9G9kbGHfydjFyckgImEjsbJrKCGGLSVy4t56ti5GLQ0hgKaNE z5+7zDBFExZeYodILGKUeLxtNROE85pR4vjRZewgVbwCWhIb/09h7WLk4GARUJU41GUNEmYT 0JO4s+04E4gtKhAm8ef4E2aIckGJH5PvsYDYIgL/mSRufhMGsZkF8iWerNgGVi8sECVx5P1d Rohd39kkJq/YDZbgFDCVON2/iRFkFzPQgvsXtSB65SU2r3nLDFIvIdDLIfF79TVWkASLgIDE t8mHWEDqJQRkJTYdgHpMUuLgihssExjFZiE5aRbC1FlIpi5gZF7FKJpakFxQnJReZKhXnJhb XJqXrpecn7uJERjJp/89693BePuA9SFGAQ5GJR5ei32XQoRYE8uKK3MPMZoCHTGRWUo0OR+Y LvJK4g2NzYwsTE1MjY3MLc2UxHkVpX4GCwmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamB0/fva UG/TLfdFinNt/WfypT8Q8FT91PT5TNHFxWacJ3O/Pb+SpNh+iqvnc8yzPX1Vh8P+iBbumvT+ 6PxrrG7fK2bKpgfMtjTqvzkn+6jMV9+q1+rX1jfqFmw4kOzhPd3/9T57A7tpn0ufcLFfeKM6 adLU4OMdTXN37HvEW3GyuXSF66UDNw9OVWIpzkg01GIuKk4EAH8HYELfAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGKsWRmVeSWpSXmKPExsVy+t9jAd0TmpdDDGZOl7XoPXeSyeLK1/ds Fuc7lzNbTLo/gcXi8sJLrBbLHpxmtNh6S9qi//FrZouzTW/YLTY9vsZqcXnXHDaLGef3MVnM mPySzYHXY9OqTjaP7d8esHrs3ZLlcb/7OJPH5iX1Hn1bVjF6NJ1qZ/X4vEkugCOqgdEmIzUx JbVIITUvOT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB+hiJYWyxJxSoFBA YnGxkr4dpgmhIW66FjCNEbq+IUFwPUYGaCBhDWPGtdXtbAXf+CvO7d3I3sC4k7eLkZNDQsBE YsLCS+wQtpjEhXvr2boYuTiEBBYxSjzetpoJwnnNKHH86DKwKl4BLYmN/6ewdjFycLAIqEoc 6rIGCbMJ6Enc2XacCcQWFQiT+HP8CTNEuaDEj8n3WEBsEYH/TBI3vwmD2MwC+RJPVmwDqxcW iJI48v4uI8Su72wSk1fsBktwCphKnO7fxAiyixlowf2LWhC98hKb17xlnsAoMAvJilkIVbOQ VC1gZF7FKJpakFxQnJSea6hXnJhbXJqXrpecn7uJEZwmnkntYFzZYHGIUYCDUYmH13LfpRAh 1sSy4srcQ4wSHMxKIryaHJdDhHhTEiurUovy44tKc1KLDzGaAv0/kVlKNDkfmMLySuINjU3M jCyNzA0tjIzNlcR5lezbQoQE0hNLUrNTUwtSi2D6mDg4pRoYD6yol46+p/5oQ+z0bOugWdlV 945PnW90fdeTdQlc62sfCB62+Gn/RuZedkSLVs9tMaO39W0Vay8F3NTJ3G4WHXL7VWzTP6ef 9XN2hU9iOSVoXSW1K9htkqDWlP6713Ylb/ronn7r/ryERxdTs3j0avd3btnKVOxfsW+hs91p RbmmlKJ9W2e2KbEUZyQaajEXFScCAAK2j8cpAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 02/05/2015 06:00 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 4 Feb 2015 21:54:45 +0100 > > The functions phy_power_on() and vunmap() perform also input > parameter validation. Thus the test around their calls is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/gpu/drm/exynos/exynos_dp_core.c | 6 ++---- > drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c > index 34d46aa..306cf1d 100644 > --- a/drivers/gpu/drm/exynos/exynos_dp_core.c > +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c > @@ -1057,14 +1057,12 @@ static int exynos_dp_create_connector(struct exynos_drm_display *display, > > static void exynos_dp_phy_init(struct exynos_dp_device *dp) > { > - if (dp->phy) > - phy_power_on(dp->phy); > + phy_power_on(dp->phy); > } > > static void exynos_dp_phy_exit(struct exynos_dp_device *dp) > { > - if (dp->phy) > - phy_power_off(dp->phy); > + phy_power_off(dp->phy); > } > > static void exynos_dp_poweron(struct exynos_drm_display *display) > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c > index e12ea90..0dd448a 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c > @@ -313,7 +313,7 @@ static void exynos_drm_fbdev_destroy(struct drm_device *dev, > struct exynos_drm_gem_obj *exynos_gem_obj = exynos_fbd->exynos_gem_obj; > struct drm_framebuffer *fb; > > - if (is_drm_iommu_supported(dev) && exynos_gem_obj->buffer->kvaddr) > + if (is_drm_iommu_supported(dev)) > vunmap(exynos_gem_obj->buffer->kvaddr); > > /* release drm framebuffer and real buffer */ > Acked-by: Joonyoung Shim Thanks.