From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757544AbbBEOUg (ORCPT <rfc822;w@1wt.eu>);
	Thu, 5 Feb 2015 09:20:36 -0500
Received: from mout.web.de ([212.227.15.14]:60219 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753251AbbBEOUe (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 5 Feb 2015 09:20:34 -0500
Message-ID: <54D37C2B.2090001@users.sourceforge.net>
Date: Thu, 05 Feb 2015 15:20:27 +0100
From: SF Markus Elfring <elfring@users.sourceforge.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Dan Carpenter <dan.carpenter@oracle.com>
CC: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-fbdev@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] au1100fb: Delete unnecessary checks before two function
 calls
References: <530C5E18.1020800@users.sourceforge.net> <alpine.DEB.2.10.1402251014170.2080@hadrien> <530CD2C4.4050903@users.sourceforge.net> <alpine.DEB.2.10.1402251840450.7035@hadrien> <530CF8FF.8080600@users.sourceforge.net> <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6> <530DD06F.4090703@users.sourceforge.net> <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6> <5317A59D.4@users.sourceforge.net> <54D36CCE.6050401@users.sourceforge.net> <20150205134114.GH5336@mwanda>
In-Reply-To: <20150205134114.GH5336@mwanda>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:z3Y8RU+SALyp6kiXQTzNNm2QcgXBi00Mh8fDjNxjgrGn0qYjIF6
 EEY7TJJZ/pUIYdJAq6pR+fhO359k25J3lh+UG/2/k/WAiSSUoKkxoSleR7bOC8SoPv0UkVn
 EhKMEosQIDtn9+msC1RiAbzpi5u3rTx6w5RajF1NmbHPHWkZg6Lqrbc49iv6G9KflZa38kB
 80r1BP0b+0mF1KaAzFY4w==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> The functions clk_enable() and clk_disable() test whether their argument
>> is NULL and then return immediately.
> 
> This isn't true for clk_enable().

I stumble on an interesting name space issue once more.


> It's frustrating that you make the same mistake over and over
> and you are fine with doing that.

I admit that there can be also risks with my update suggestions
in similar ways to contributions from other software developers.

A specific function implementation exists which performs also input
parameter validation.
http://lxr.free-electrons.com/source/drivers/sh/clk/core.c#L291

Such variants might not fit to the functions au1100fb_drv_suspend()
and au1100fb_drv_resume().


Do you want that I send a reduced patch?

Regards,
Markus