From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758180AbbBEQNv (ORCPT ); Thu, 5 Feb 2015 11:13:51 -0500 Received: from mout.web.de ([212.227.15.14]:52585 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbbBEQNt (ORCPT ); Thu, 5 Feb 2015 11:13:49 -0500 Message-ID: <54D396B7.9060303@users.sourceforge.net> Date: Thu, 05 Feb 2015 17:13:43 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Greg Kroah-Hartman , linux-usb@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] USB: whci-hcd: Delete an unnecessary check before the function call "usb_put_hcd" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:CD5Sg2QhZEP33gYSDI2SCRvDMXBM0b+6kZfxZ7Vig9YMg7JFoqW t38z2+fHzB4bTQ4hKEMOm02A4uSGq5i8h/rZngGm9eS9/t2AuBRtYSxPBnohhoXpVXbrxT/ QMtbInYU/XeVSt2QCYljbaHbIDbFY2bkO7DMFtcuHfXRr9mwWvt6Chs6IzDcQG2jN1W1i1R agilxn0aISrIK4KhH242g== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 5 Feb 2015 16:54:12 +0100 The usb_put_hcd() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/usb/host/whci/hcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/whci/hcd.c b/drivers/usb/host/whci/hcd.c index d7b363a..43626c4 100644 --- a/drivers/usb/host/whci/hcd.c +++ b/drivers/usb/host/whci/hcd.c @@ -313,8 +313,7 @@ error_wusbhc_create: uwb_rc_put(wusbhc->uwb_rc); error: whc_clean_up(whc); - if (usb_hcd) - usb_put_hcd(usb_hcd); + usb_put_hcd(usb_hcd); return ret; } -- 2.2.2