From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754463AbbBEUpK (ORCPT ); Thu, 5 Feb 2015 15:45:10 -0500 Received: from mout.web.de ([212.227.17.11]:52808 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751807AbbBEUpH (ORCPT ); Thu, 5 Feb 2015 15:45:07 -0500 Message-ID: <54D3D64E.6060503@users.sourceforge.net> Date: Thu, 05 Feb 2015 21:45:02 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: linux-usb@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] uwb/whci: Delete an unnecessary check before the function call "umc_device_unregister" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:8km/zymnO48J9OrZ8GF4uNMvQj+cDgBTFLO7+Ej/keFowhnv02M SNqfMFLZ4U4RiICc/IEstxn5+DpgfdNoUTR8lIH5g5tQfdSZCWSGWK6XDW+8/sPz11dk5FU 0bSEZ8ppwYeRvJ2j8KMwv26eHKOgV6u0O7pK77v4Z/XZpHYQl3MKXM6LZ1ZPgKe+n95/4TE YLMvQSN1VZ/ttUlcTmGIw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 5 Feb 2015 21:40:29 +0100 The umc_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/uwb/whci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/uwb/whci.c b/drivers/uwb/whci.c index 46b7cfc..c3ee39a 100644 --- a/drivers/uwb/whci.c +++ b/drivers/uwb/whci.c @@ -133,8 +133,7 @@ static void whci_del_cap(struct whci_card *card, int n) { struct umc_dev *umc = card->devs[n]; - if (umc != NULL) - umc_device_unregister(umc); + umc_device_unregister(umc); } static int whci_n_caps(struct pci_dev *pci) -- 2.2.2