From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751486AbbBEVHv (ORCPT ); Thu, 5 Feb 2015 16:07:51 -0500 Received: from mout.web.de ([212.227.15.3]:57504 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874AbbBEVHu (ORCPT ); Thu, 5 Feb 2015 16:07:50 -0500 Message-ID: <54D3DB9F.5040100@users.sourceforge.net> Date: Thu, 05 Feb 2015 22:07:43 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Anil Gurumurthy , "James E. J. Bottomley" , Sudarsana Kalluru , linux-scsi@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] SCSI-bfa: Delete more unnecessary checks before the function call "vfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Fc/Xlklqt6I3TIY+LPVdVv2IBJz4F5eH+Idw2QcsCCgTkrw9+aK ksCw/8F/+gcdXNthZ/JM1rPeuhQgAdl34H8utTCMf09VVL4z0ON9kYFNCNr3PsJbXs6OJL5 tp0ZoIKz5Bgl/WxVzhwbW7wu8xpDXsX0/PKEEnz1bsmHWhTOBi3T/ciNSe98raYuIg58eC1 aKiuAPyaUaHi1iqI6Narg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 5 Feb 2015 22:02:16 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/scsi/bfa/bfad.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c index e90a374..05c8ca0 100644 --- a/drivers/scsi/bfa/bfad.c +++ b/drivers/scsi/bfa/bfad.c @@ -1810,11 +1810,11 @@ bfad_load_fwimg(struct pci_dev *pdev) static void bfad_free_fwimg(void) { - if (bfi_image_ct2_size && bfi_image_ct2) + if (bfi_image_ct2_size) vfree(bfi_image_ct2); - if (bfi_image_ct_size && bfi_image_ct) + if (bfi_image_ct_size) vfree(bfi_image_ct); - if (bfi_image_cb_size && bfi_image_cb) + if (bfi_image_cb_size) vfree(bfi_image_cb); } -- 2.2.2