From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757028AbbBGRXv (ORCPT <rfc822;w@1wt.eu>);
	Sat, 7 Feb 2015 12:23:51 -0500
Received: from mout.web.de ([212.227.15.4]:53455 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753837AbbBGRXs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 7 Feb 2015 12:23:48 -0500
Message-ID: <54D64A1E.40405@users.sourceforge.net>
Date: Sat, 07 Feb 2015 18:23:42 +0100
From: SF Markus Elfring <elfring@users.sourceforge.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Dan Carpenter <dan.carpenter@oracle.com>,
        Julia Lawall <julia.lawall@lip6.fr>
CC: "James E. J. Bottomley" <JBottomley@parallels.com>,
        QLogic-Storage-Upstream@qlogic.com, linux-scsi@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/4] SCSI-QLA4...: Less function calls in qla4xxx_is_session_exists()
 after error detection
References: <alpine.DEB.2.10.1402251840450.7035@hadrien> <530CF8FF.8080600@users.sourceforge.net> <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6> <530DD06F.4090703@users.sourceforge.net> <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6> <5317A59D.4@users.sourceforge.net> <54D53BE4.7010807@users.sourceforge.net> <54D53CF1.8050009@users.sourceforge.net> <20150207093322.GA5206@mwanda> <alpine.DEB.2.02.1502071110330.2241@localhost6.localdomain6> <20150207103249.GA5155@mwanda>
In-Reply-To: <20150207103249.GA5155@mwanda>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:XGd1gTrtPAF2UAAcFteFDaQMl/z8ExfBEYL4iCd4sxfNgQ1MR+o
 jyjYrQeheppEb/tqSd4WP4pEQbVgXMZzenVf+ynNoWckzHcs2l9S4SBlHMYvpjBqtTX2Jd/
 M8Tl0GQU/aF92Fd8tOvvw9YAgz0EPRPwQKCaTp53P/+++lcbA88ycIpr+rNcF/MvUb29bfC
 UIxWgVeS8Nw5osxV1+RBg==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> 1)  People gloss over initializers without reading them.

I would find such a habit strange.


>     You shouldn't put complicated code in initializers.

Does the affected memory allocation fall into such a category?


> 2)  It means you have to put a line of separation between the allocation
>     and the NULL check, but they should be next to each other.

Would you like to extend the Linux coding style documentation?

Regards,
Markus