From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751469AbbBLVtf (ORCPT ); Thu, 12 Feb 2015 16:49:35 -0500 Received: from out114-135.biz.mail.alibaba.com ([205.204.114.135]:51961 "EHLO out11.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750810AbbBLVte (ORCPT ); Thu, 12 Feb 2015 16:49:34 -0500 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.09609486|-1;FP=0|0|0|0|0|-1|-1|-1;HT=r41g03005;MF=gang.chen@sunrus.com.cn;PH=DS;RN=7;RT=7;SR=0; Message-ID: <54DD21AB.8070700@sunrus.com.cn> Date: Fri, 13 Feb 2015 05:56:59 +0800 From: Chen Gang S User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Patrice Chotard , srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, mchehab@osg.samsung.com CC: "linux-arm-kernel@lists.infradead.org" , kernel@stlinux.com, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] rc: st_rc: Use CONFIG_PM_SLEEP instead of CONFIG_PM for st_rc_suspend() and st_rc_resume() References: <54CE3B47.6050909@sunrus.com.cn> <54CF2D36.5060002@st.com> In-Reply-To: <54CF2D36.5060002@st.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Maintainers: Please help to process this patch, when you have time. Thanks. On 2/2/15 15:54, Patrice Chotard wrote: > Hi Chen > > On 02/01/2015 03:42 PM, Chen Gang S wrote: >> st_rc_suspend() and st_rc_resume() depend on CONFIG_PM_SLEEP finally, so >> they need CONFIG_PM_SLEEP instead of CONFIG_PM, or they will cause build >> warning (with allmodconfig under xtensa): >> >> CC [M] drivers/media/pci/smipcie/smipcie.o >> drivers/media/rc/st_rc.c:338:12: warning: 'st_rc_suspend' defined but not used [-Wunused-function] >> static int st_rc_suspend(struct device *dev) >> ^ >> drivers/media/rc/st_rc.c:359:12: warning: 'st_rc_resume' defined but not used [-Wunused-function] >> static int st_rc_resume(struct device *dev) >> ^ >> >> Signed-off-by: Chen Gang >> --- >> drivers/media/rc/st_rc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c >> index 0e758ae..fbfe958 100644 >> --- a/drivers/media/rc/st_rc.c >> +++ b/drivers/media/rc/st_rc.c >> @@ -334,7 +334,7 @@ err: >> return ret; >> } >> -#ifdef CONFIG_PM >> +#ifdef CONFIG_PM_SLEEP >> static int st_rc_suspend(struct device *dev) >> { >> struct st_rc_device *rc_dev = dev_get_drvdata(dev); > > Acked-by: Patrice Chotard > Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed