From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbbBMBoX (ORCPT ); Thu, 12 Feb 2015 20:44:23 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:59971 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751241AbbBMBoW (ORCPT ); Thu, 12 Feb 2015 20:44:22 -0500 Message-ID: <54DD56F4.5040200@codeaurora.org> Date: Thu, 12 Feb 2015 17:44:20 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Heikki Krogerus , Felipe Balbi , Greg Kroah-Hartman CC: Baolu Lu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] usb: add bus type for USB ULPI References: <1422025978-178336-1-git-send-email-heikki.krogerus@linux.intel.com> <1422025978-178336-2-git-send-email-heikki.krogerus@linux.intel.com> In-Reply-To: <1422025978-178336-2-git-send-email-heikki.krogerus@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/23/15 07:12, Heikki Krogerus wrote: > diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c > index e614ef6..753cb08 100644 > --- a/scripts/mod/file2alias.c > +++ b/scripts/mod/file2alias.c > @@ -1176,6 +1176,19 @@ static int do_rio_entry(const char *filename, > } > ADD_TO_DEVTABLE("rapidio", rio_device_id, do_rio_entry); > > +/* Looks like: mei:S */ This comment doesn't look right. > +static int do_ulpi_entry(const char *filename, void *symval, > + char *alias) > +{ > + DEF_FIELD(symval, ulpi_device_id, vendor); > + DEF_FIELD(symval, ulpi_device_id, product); > + > + sprintf(alias, "ulpi:v%04xp%04x", vendor, product); > + > + return 1; > +} > +ADD_TO_DEVTABLE("ulpi", ulpi_device_id, do_ulpi_entry); > + -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project