From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933442AbbBQKBJ (ORCPT ); Tue, 17 Feb 2015 05:01:09 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:7664 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754786AbbBQKBG (ORCPT ); Tue, 17 Feb 2015 05:01:06 -0500 Message-ID: <54E31154.3020308@huawei.com> Date: Tue, 17 Feb 2015 18:00:52 +0800 From: "Yun Wu (Abel)" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Marc Zyngier CC: "tglx@linutronix.de" , "jason@lakedaemon.net" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 3/6] irqchip: gicv3-its: limit order of DT size to MAX_ORDER References: <1423992723-5028-1-git-send-email-wuyun.wu@huawei.com> <1423992723-5028-4-git-send-email-wuyun.wu@huawei.com> <20150217091945.1c47e92f@arm.com> In-Reply-To: <20150217091945.1c47e92f@arm.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.24.136] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/2/17 17:19, Marc Zyngier wrote: > On Sun, 15 Feb 2015 09:32:00 +0000 > Yun Wu wrote: > >> When required DT size is out of the kmalloc()'s capability, the whole > > Nit: Using the DT acronym is very confusing here, as it means "Device > Tree" to most people, including me. Please use "Device Table" instead. > > Also, the reference to kmalloc is wrong, as we're really using the page > allocator. OK, I will get the description fixed in the next version. > >> ITS will fail in probing. This actually is not the hardware's problem >> and is mainly a limitation of the kernel memory allocator. This patch >> will keep ITS going on to the next initializaion step with an explicit >> warning. >> >> Signed-off-by: Yun Wu >> --- >> drivers/irqchip/irq-gic-v3-its.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/irqchip/irq-gic-v3-its.c >> b/drivers/irqchip/irq-gic-v3-its.c index f5bfa42..de36606 100644 >> --- a/drivers/irqchip/irq-gic-v3-its.c >> +++ b/drivers/irqchip/irq-gic-v3-its.c >> @@ -828,6 +828,12 @@ static int its_alloc_tables(struct its_node *its) >> u32 ids = GITS_TYPER_DEVBITS(typer); >> >> order = get_order((1UL << ids) * entry_size); >> + if (order >= MAX_ORDER) { >> + pr_warn("%s: DT size too large, >> reduce to %u pages\n", >> + >> its->msi_chip.of_node->full_name, >> + 1 << order); >> + order = MAX_ORDER; >> + } >> } > > Something is wrong here. Either (order == MAX_ORDER) is acceptable, or > it is not. Also, your warning says that you're reducing the size to a > new value, but you're displaying the size you can't handle. That > message should be fixed. > Yes, my fault, I will fix them. Thanks, Abel