From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
To: Matt Fleming <matt.fleming@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [Patch v2] firmware: dmi_scan: fix dmi scan to handle "End of Table" structure
Date: Wed, 18 Feb 2015 12:18:37 +0200 [thread overview]
Message-ID: <54E466FD.2090601@linaro.org> (raw)
In-Reply-To: <CAKv+Gu_6grFhkeSReR4ZETRQXE2bjVtqyY5gnBAD1rYucU6h3g@mail.gmail.com>
Hi, Matt
Could you please pick up this patch.
On 02/05/2015 12:36 PM, Ard Biesheuvel wrote:
> On 4 February 2015 at 14:22, Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> wrote:
>> The dmi-sysfs should create "End of Table" entry, that is type 127.
>> But after adding initial SMBIOS v3 support the 127-0 entry is not
>> handled any more, as result it's not created in sysfs.
>> This is important because the size of whole DMI table must correspond
>> to sum of all DMI entry sizes.
>>
>> So move "end-of-table" check after it's handled by decode.
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> Reviewed-by: Ard Biesheuvel <ard@linaro.org>
>
>> ---
>>
>> v2..v1:
>> Move end of table check after it's handled instead of removing
>> Correct commit
>>
>> drivers/firmware/dmi_scan.c | 13 +++++++------
>> 1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
>> index c5f7b4e..a44b87c 100644
>> --- a/drivers/firmware/dmi_scan.c
>> +++ b/drivers/firmware/dmi_scan.c
>> @@ -93,12 +93,6 @@ static void dmi_table(u8 *buf, int len, int num,
>> const struct dmi_header *dm = (const struct dmi_header *)data;
>>
>> /*
>> - * 7.45 End-of-Table (Type 127) [SMBIOS reference spec v3.0.0]
>> - */
>> - if (dm->type == DMI_ENTRY_END_OF_TABLE)
>> - break;
>> -
>> - /*
>> * We want to know the total length (formatted area and
>> * strings) before decoding to make sure we won't run off the
>> * table in dmi_decode or dmi_string
>> @@ -108,6 +102,13 @@ static void dmi_table(u8 *buf, int len, int num,
>> data++;
>> if (data - buf < len - 1)
>> decode(dm, private_data);
>> +
>> + /*
>> + * 7.45 End-of-Table (Type 127) [SMBIOS reference spec v3.0.0]
>> + */
>> + if (dm->type == DMI_ENTRY_END_OF_TABLE)
>> + break;
>> +
>> data += 2;
>> i++;
>> }
>> --
>> 1.9.1
>>
next prev parent reply other threads:[~2015-02-18 10:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 14:22 [Patch v2] firmware: dmi_scan: fix dmi scan to handle "End of Table" structure Ivan Khoronzhuk
2015-02-05 10:36 ` Ard Biesheuvel
2015-02-18 10:18 ` Ivan Khoronzhuk [this message]
2015-02-18 13:04 ` Matt Fleming
2015-02-18 13:20 ` Ivan Khoronzhuk
2015-02-18 13:38 ` Matt Fleming
2015-02-18 13:54 ` Ivan Khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E466FD.2090601@linaro.org \
--to=ivan.khoronzhuk@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).