From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752358AbbBSJZo (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 Feb 2015 04:25:44 -0500
Received: from mail-wi0-f173.google.com ([209.85.212.173]:52422 "EHLO
	mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752056AbbBSJZl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 Feb 2015 04:25:41 -0500
Message-ID: <54E5AC11.8070608@plexistor.com>
Date: Thu, 19 Feb 2015 11:25:37 +0200
From: Boaz Harrosh <boaz@plexistor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Christoph Hellwig <hch@infradead.org>,
        Dan Williams <dan.j.williams@intel.com>
CC: Matthew Wilcox <willy@linux.intel.com>, Ingo Molnar <mingo@redhat.com>,
        Ross Zwisler <ross.zwisler@linux.intel.com>, x86@kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "Roger C. Pao" <rcpao.enmotus@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-nvdimm <linux-nvdimm@ml01.01.org>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [Linux-nvdimm] [PATCH 0/2] e820: Fix handling of NvDIMM chips
References: <54E1CF5B.9020905@plexistor.com> <20150216220302.GF3364@wil.cx> <54E2FEF2.8060701@plexistor.com> <CAPcyv4if=9Cv__4D0oE9ds1C37TRDkURSVtyB8_k9Nc3WUwbrg@mail.gmail.com> <20150219004731.GA5477@infradead.org>
In-Reply-To: <20150219004731.GA5477@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/19/2015 02:47 AM, Christoph Hellwig wrote:
> On Wed, Feb 18, 2015 at 10:15:32AM -0800, Dan Williams wrote:
>> In fact it was originally "type-6" until ACPI 5 claimed that number
>> for official use, so these platforms, with early proof-of-concept
>> nvdimm support, have already gone through one transition to a new
>> number.  They need to do the same once an official number for nvdimm
>> support is published.
>>
>> Put another way, these early platforms are already using out-of-tree
>> patches for nvdimm enabling.  They can continue to do so, or switch to
>> standard methods when the standard is published.
> 
> Not supporting hardware that is widely avaiable (I have some, too)
> is not very user friendly.
> 
> I'll submit a patch allowing a nvdimm_type= kernel option that allows
> to detect them, but will do nothing by default.  The code needed is very
> small and it would be very useful for all kinds of projects.
> 

I do not see why you need the nvdimm_type= kernel option at all.

I have here a script that auto detects any NvDIMM. It works with all
the chips that I have access to. And Also it has support for if you have
memmap=sss\$aaa.
For all these detected regions it will load a pmem device.

It is easy to filter for any type of memory you want. What
will the (annoying) kernel option give you?

OK I might be jumping the guns, send the patch and I'll look
at it.

Thanks
Boaz