From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755428AbbCCBw3 (ORCPT ); Mon, 2 Mar 2015 20:52:29 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:39632 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754374AbbCCBw1 (ORCPT ); Mon, 2 Mar 2015 20:52:27 -0500 Message-ID: <54F513C0.4000706@infradead.org> Date: Mon, 02 Mar 2015 17:52:00 -0800 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Vladimir Murzin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org CC: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, lauraa@codeaurora.org, catalin.marinas@arm.com, will.deacon@arm.com, linux@arm.linux.org.uk, arnd@arndb.de, mark.rutland@arm.com, ard.biesheuvel@linaro.org Subject: Re: [RFC PATCH 1/4] mm: move memtest under /mm References: <1425308145-20769-1-git-send-email-vladimir.murzin@arm.com> <1425308145-20769-2-git-send-email-vladimir.murzin@arm.com> In-Reply-To: <1425308145-20769-2-git-send-email-vladimir.murzin@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/15 06:55, Vladimir Murzin wrote: > There is nothing platform dependent in the core memtest code, so other platform > might benefit of this feature too. > > Signed-off-by: Vladimir Murzin > --- > arch/x86/Kconfig | 11 ---- > arch/x86/include/asm/e820.h | 8 --- > arch/x86/mm/Makefile | 2 - > arch/x86/mm/memtest.c | 118 ------------------------------------------- > include/linux/memblock.h | 8 +++ > lib/Kconfig.debug | 11 ++++ > mm/Makefile | 1 + > mm/memtest.c | 118 +++++++++++++++++++++++++++++++++++++++++++ > 8 files changed, 138 insertions(+), 139 deletions(-) > delete mode 100644 arch/x86/mm/memtest.c > create mode 100644 mm/memtest.c > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index c5cefb3..8eb064fd 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1732,6 +1732,17 @@ config TEST_UDELAY > > If unsure, say N. > > +config MEMTEST > + bool "Memtest" > + ---help--- > + This option adds a kernel parameter 'memtest', which allows memtest > + to be set. > + memtest=0, mean disabled; -- default > + memtest=1, mean do 1 test pattern; > + ... > + memtest=4, mean do 4 test patterns. This sort of implies a max of 4 test patterns, but it seems to be 17 if I counted correctly, so if someone wants to test all of the possible 'memtest' patterns, they would need to use 'memtest=17', is that correct? > + If you are unsure how to answer this question, answer N. Thanks, -- ~Randy