From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755880AbbCCTX7 (ORCPT ); Tue, 3 Mar 2015 14:23:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57436 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbbCCTX6 (ORCPT ); Tue, 3 Mar 2015 14:23:58 -0500 Message-ID: <54F60A33.7020900@redhat.com> Date: Tue, 03 Mar 2015 14:23:31 -0500 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Oleg Nesterov , Tavis Ormandy , Borislav Petkov , Ingo Molnar CC: Andy Lutomirski , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] x86/regsets: change xstateregs_get/set to use ->xsave.i387 rather than ->fxsave References: <20150301184650.GA12758@redhat.com> <20150301185943.GA14318@redhat.com> <20150302174818.GA16886@redhat.com> <20150302183210.GA23085@redhat.com> <20150302183237.GB23085@redhat.com> In-Reply-To: <20150302183237.GB23085@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/2015 01:32 PM, Oleg Nesterov wrote: > Cosmetic. xstateregs_get() and xstateregs_set() abuse ->fxsave to access > xsave->i387.sw_reserved. This is correct, ->fxsave and xsave->i387 share > the same memory, but imho this looks confusing. > > And we can make this code more readable if we add "struct xsave_struct *" > local. > > Signed-off-by: Oleg Nesterov Reviewed-by: Rik van Riel -- All rights reversed