From: Arun Ramamurthy <arun.ramamurthy@broadcom.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"Russell King" <linux@arm.linux.org.uk>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
Dmitry Torokhov <dtor@google.com>,
Anatol Pomazau <anatol@google.com>,
Jonathan Richardson <jonathar@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH] video: ARM CLCD: Added support for FBIO_WAITFORVSYNC
Date: Tue, 3 Mar 2015 16:33:43 -0800 [thread overview]
Message-ID: <54F652E7.4080104@broadcom.com> (raw)
In-Reply-To: <CAL_JsqJfA3Pxvdux-Um9nFoaZpRh30S9d1TQid_TchDH_qo7Ow@mail.gmail.com>
On 15-03-02 03:29 PM, Rob Herring wrote:
> On Wed, Feb 25, 2015 at 3:01 PM, Arun Ramamurthy
> <arun.ramamurthy@broadcom.com> wrote:
>> Added ioctl and interrupt handler functions to support FBIO_WAITFORVSYNC
>> Also corrected documentation to make interrupts and interrupt-names
>> optional as they are not required properties.
>>
>> Reviewed-by: Ray Jui <rjui@broadcom.com>
>> Reviewed-by: Scott Branden <sbranden@broadcom.com>
>> Signed-off-by: Arun Ramamurthy <arun.ramamurthy@broadcom.com>0
>> ---
>> .../devicetree/bindings/video/arm,pl11x.txt | 11 +--
>
> Please split bindings to separate patches.
Rob, I looked at the history of patches to this driver and all them
included changes to the documentation in the same patch so I followed a
similar model. I assumed that a separate patch was only required when
the documentation was being added from scratch and not when modifying a
few lines. Is this not the case?
>
>> drivers/video/fbdev/amba-clcd.c | 82 ++++++++++++++++++++++
>> include/linux/amba/clcd.h | 4 ++
>> 3 files changed, 89 insertions(+), 8 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/video/arm,pl11x.txt b/Documentation/devicetree/bindings/video/arm,pl11x.txt
>> index 2262cdb..7d19024 100644
>> --- a/Documentation/devicetree/bindings/video/arm,pl11x.txt
>> +++ b/Documentation/devicetree/bindings/video/arm,pl11x.txt
>> @@ -10,14 +10,6 @@ Required properties:
>>
>> - reg: base address and size of the control registers block
>>
>> -- interrupt-names: either the single entry "combined" representing a
>> - combined interrupt output (CLCDINTR), or the four entries
>> - "mbe", "vcomp", "lnbu", "fuf" representing the individual
>> - CLCDMBEINTR, CLCDVCOMPINTR, CLCDLNBUINTR, CLCDFUFINTR interrupts
>> -
>> -- interrupts: contains an interrupt specifier for each entry in
>> - interrupt-names
>> -
>> - clock-names: should contain "clcdclk" and "apb_pclk"
>>
>> - clocks: contains phandle and clock specifier pairs for the entries
>> @@ -54,6 +46,9 @@ Optional properties:
>> It can be used to configure a virtual y resolution. It
>> must be a value larger than the actual y resolution.
>>
>> +- interrupts: contains an interrupt specifier for the clcd vcomp interrupt
>> + This is required for the driver to handle FBIO_WAITFORVSYNC ioctls.
>> +
>
> What happened to interrupt-names?
As mentioned before, these changes to the documentation will be undone
in V2. Thanks
>
> Rob
>
next prev parent reply other threads:[~2015-03-04 0:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 21:01 [PATCH] video: ARM CLCD: Added dt support to set tim2 register Arun Ramamurthy
2015-02-25 21:01 ` [PATCH] video: ARM CLCD: Added support for FBIOPAN_DISPLAY and virtual y resolution Arun Ramamurthy
2015-03-02 16:08 ` Pawel Moll
2015-03-02 16:11 ` Russell King - ARM Linux
2015-03-02 19:09 ` Arun Ramamurthy
2015-03-02 19:12 ` Russell King - ARM Linux
2015-03-02 23:22 ` Rob Herring
2015-03-04 0:31 ` Arun Ramamurthy
2015-02-25 21:01 ` [PATCH] video: ARM CLCD: Added support for FBIO_WAITFORVSYNC Arun Ramamurthy
2015-03-02 16:00 ` Pawel Moll
2015-03-02 19:09 ` Arun Ramamurthy
2015-03-03 10:01 ` Pawel Moll
2015-03-04 0:35 ` Arun Ramamurthy
2015-03-02 23:27 ` Rob Herring
2015-03-04 0:31 ` Arun Ramamurthy
2015-03-02 23:29 ` Rob Herring
2015-03-04 0:33 ` Arun Ramamurthy [this message]
2015-02-25 21:01 ` [PATCH] video: ARM CLCD: Correcting timing checks for STN and TFT dispalys Arun Ramamurthy
2015-03-02 16:11 ` [PATCH] video: ARM CLCD: Added dt support to set tim2 register Pawel Moll
2015-03-02 19:09 ` Arun Ramamurthy
2015-03-03 10:02 ` Pawel Moll
2015-03-03 10:22 ` Pawel Moll
2015-03-04 0:37 ` Arun Ramamurthy
2015-03-05 10:59 ` Pawel Moll
2015-03-09 16:16 ` Russell King - ARM Linux
2016-02-10 13:58 ` Linus Walleij
2016-02-10 17:48 ` Ray Jui
2016-02-15 13:25 ` Linus Walleij
[not found] ` <CAE_wzQ-s4-T8wDJjwtLkr73_1j8JpRVxBaBJRfskMeACdUxPig@mail.gmail.com>
2016-02-17 17:42 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F652E7.4080104@broadcom.com \
--to=arun.ramamurthy@broadcom.com \
--cc=anatol@google.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=dtor@google.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jonathar@broadcom.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=sbranden@broadcom.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).