From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754758AbbCFOtA (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Mar 2015 09:49:00 -0500
Received: from mail-la0-f45.google.com ([209.85.215.45]:40817 "EHLO
	mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754499AbbCFOs4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Mar 2015 09:48:56 -0500
Message-ID: <54F9BE55.90601@cogentembedded.com>
Date: Fri, 06 Mar 2015 17:48:53 +0300
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: yong.wu@mediatek.com, Rob Herring <robh+dt@kernel.org>,
        Joerg Roedel <joro@8bytes.org>,
        Matthias Brugger <matthias.bgg@gmail.com>
CC: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org,
        srv_heupstream@mediatek.com, Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, linux-kernel@vger.kernel.org,
        Tomasz Figa <tfiga@google.com>, iommu@lists.linux-foundation.org,
        Daniel Kurtz <djkurtz@google.com>, Sasha Hauer <kernel@pengutronix.de>,
        linux-mediatek@lists.infradead.org,
        Robin Murphy <robin.murphy@arm.com>,
        linux-arm-kernel@lists.infradead.org,
        Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding
References: <1425638900-24989-1-git-send-email-yong.wu@mediatek.com> <1425638900-24989-4-git-send-email-yong.wu@mediatek.com>
In-Reply-To: <1425638900-24989-4-git-send-email-yong.wu@mediatek.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 3/6/2015 1:48 PM, yong.wu@mediatek.com wrote:

> From: Yong Wu <yong.wu@mediatek.com>

> This patch add smi binding document.

> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
>   .../devicetree/bindings/soc/mediatek/mediatek,smi.txt   | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt

> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt b/Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt
> new file mode 100644
> index 0000000..0fc9d1a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt
> @@ -0,0 +1,17 @@
> +SMI hardware block diagram please help check <bindings/iommu/mediatek,iommu.txt>
> +
> +Required properties:
> +- compatible : must be "mediatek,mediatek,mt8173-smi-larb"

    One "mediatek," is enough. :-)

> +- reg : the register of each local arbiter
> +- clocks : the clocks of each local arbiter
> +- clock-name: larb_sub*(3 clockes at most)

    clock-names.

> +
> +Example:
> +	larb1:larb@16010000 {
> +	        compatible = "mediatek,mt8173-smi-larb";
> +		reg = <0 0x16010000 0 0x1000>;
> +		clocks = <&mmsys MM_SMI_COMMON>,
> +		        <&vdecsys VDEC_CKEN>,

    Please align with the < above.

> +                        <&vdecsys VDEC_LARB_CKEN>;

    Use tabs instead of spaces, please.

> +		clock-names = "larb_sub0", "larb_sub1", "larb_sub2";
> +	};

WBR, Sergei